Rafael Sadowski writes:
> On Mon Apr 05, 2021 at 04:22:27PM +0200, Rafael Sadowski wrote:
>> On Sun Mar 28, 2021 at 08:58:22PM +0200, Rafael Sadowski wrote:
>> > On Sat Mar 27, 2021 at 09:29:14AM +0100, Rafael Sadowski wrote:
>> > > Hi ports@,
>> > >
>> > > I would like to introduce a small minimalist UDisks2 service
>> > > implementation for OpenBSD to you. It is a more or less complete rework
>> > > of FreeBSD's (bsdutils/bsdisks).
>> > >
>> > > Basic functions are available. The goal was to be able to list block
>> > > devices under applications like KDE dolphin.
>> > >
>> > > Feeback, opinions, tests and OKs are welcome!
Here is a diff with some nits:
- MASTER_SITES and RUN_DEPENDS whitespace
- 80 char ruler ---
- Use === for sections and --- for subsections
- ${LOCALSTATEDIR} instead of /var
- already root so no need for doas
I tested with dolphin-kf5 and devices show up in the left
panel. However, I was not able to get logging to work. Logs do not show
up in /var/log/messages nor /var/log/openbsdisks2.log following the
instructions.
>
> Would someone so kind and could review the port from the port
> perspective? I would love to import that. (post-lock)
Index: Makefile
===================================================================
RCS file: /cvsnam/ports/sysutils/openbsdisks2/Makefile,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 Makefile
--- Makefile 24 Apr 2021 09:01:07 -0000 1.1
+++ Makefile 24 Apr 2021 10:17:55 -0000
@@ -16,11 +16,11 @@ PERMIT_PACKAGE = Yes
WANTLIB += ${COMPILER_LIBCXX} Qt5Core Qt5DBus c m util
-MASTER_SITES=
https://github.com/sizeofvoid/openbsdisks2/releases/download/v${V}/
+MASTER_SITES =
https://github.com/sizeofvoid/openbsdisks2/releases/download/v${V}/
MODULES = devel/cmake \
x11/qt5
-RUN_DEPENDS+= x11/dbus,-suid
+RUN_DEPENDS += x11/dbus,-suid
.include <bsd.port.mk>
Index: pkg/README
===================================================================
RCS file: /cvsnam/ports/sysutils/openbsdisks2/pkg/README,v
retrieving revision 1.1
diff -u -p -u -p -r1.1 README
--- pkg/README 24 Apr 2021 09:01:07 -0000 1.1
+++ pkg/README 24 Apr 2021 10:17:55 -0000
@@ -1,28 +1,28 @@
$OpenBSD: README,v 1.3 2020/05/02 06:35:12 ajacoutot Exp $
-+-----------------------------------------------------------------------
++-------------------------------------------------------------------------------
| Running ${PKGSTEM} on OpenBSD
-+-----------------------------------------------------------------------
++-------------------------------------------------------------------------------
OpenBSDisks2 is started automatically when an application makes a DBus
org.freedesktop.UDisks2 request.
Security
---------
+========
Please note that OpenBSDisks2 is run as root.
Logging
--------
+=======
Logging is enabled by default to syslogd(8) with the tag "openbsdisks2". If you
want to use a separate file for logs, add the following lines to the top of
${SYSCONFDIR}/syslog.conf:
!!openbsdisks2
- *.* /var/log/openbsdisks2.log
+ *.* ${LOCALSTATEDIR}/log/openbsdisks2.log
!*
create logfile:
- # doas install -D -m 0640 /dev/null /var/log/openbsdisks2.log
+ # install -D -m 0640 /dev/null ${LOCALSTATEDIR}/log/openbsdisks2.log
and restart syslogd(8):
# rcctl reload syslogd
