On 2021/04/24 03:28, Nam Nguyen wrote:
> Rafael Sadowski writes:
>
> > On Mon Apr 05, 2021 at 04:22:27PM +0200, Rafael Sadowski wrote:
> >> On Sun Mar 28, 2021 at 08:58:22PM +0200, Rafael Sadowski wrote:
> >> > On Sat Mar 27, 2021 at 09:29:14AM +0100, Rafael Sadowski wrote:
> >> > > Hi ports@,
> >> > >
> >> > > I would like to introduce a small minimalist UDisks2 service
> >> > > implementation for OpenBSD to you. It is a more or less complete rework
> >> > > of FreeBSD's (bsdutils/bsdisks).
> >> > >
> >> > > Basic functions are available. The goal was to be able to list block
> >> > > devices under applications like KDE dolphin.
> >> > >
> >> > > Feeback, opinions, tests and OKs are welcome!
>
> Here is a diff with some nits:
> - MASTER_SITES and RUN_DEPENDS whitespace
> - 80 char ruler ---
> - Use === for sections and --- for subsections
> - ${LOCALSTATEDIR} instead of /var
hmm, could be ${LOCALSTATEDIR}, but I would think /var/log is more normal
for something used as a log directory in syslog.conf.
> --------
> +=======
> Logging is enabled by default to syslogd(8) with the tag "openbsdisks2". If
> you
> want to use a separate file for logs, add the following lines to the top of
> ${SYSCONFDIR}/syslog.conf:
This should definitely be /etc not ${SYSCONFDIR}, in the highly unlikely
event that somebody has changed SYSCONFDIR for ports things, syslogd still
won't be looking in the alternative location for its config.
>
> !!openbsdisks2
> - *.* /var/log/openbsdisks2.log
> + *.* ${LOCALSTATEDIR}/log/openbsdisks2.log
> !*
>
> create logfile:
> - # doas install -D -m 0640 /dev/null /var/log/openbsdisks2.log
> + # install -D -m 0640 /dev/null ${LOCALSTATEDIR}/log/openbsdisks2.log
>
> and restart syslogd(8):
> # rcctl reload syslogd
>
