On 2021/11/17 18:45, Omar Polo wrote:
> > i think you should make sure that it depends on the correct version
> > then, using wxWidgets->=3.0.5.1p1.
>
> my reasoning was that since the -webkit package is new then the explicit
> versioning wasn't needed. I've re-added the version check thought.
Your reasoning is correct, the LIB_DEPENDS cannot be satisfied unless
wxWidgets is from after adding the subpackage, so no need for the version check.
It doesn't hurt to add it, but every unnecessary version check is an extra
thing to fix if an EPOCH gets bumped (and it's hard to spot) so better not
use version checks unless they're really needed.
> retrieving revision 1.36
> diff -u -p -r1.36 Makefile
> --- Makefile 10 Sep 2021 13:46:28 -0000 1.36
> +++ Makefile 17 Nov 2021 17:22:43 -0000
> @@ -2,10 +2,9 @@
>
> COMMENT= cross-platform gettext catalogs (PO-files) editor
>
> -V= 2.4.3
> +V= 3.0
> DISTNAME= poedit-${V}
> CATEGORIES= devel
> -REVISION= 0
>
> HOMEPAGE= https://www.poedit.net/
>
> @@ -19,10 +18,10 @@ WANTLIB += atk-1.0 boost_regex-mt boost_
> WANTLIB += cairo cairo-gobject enchant-2 gdk-3 gdk_pixbuf-2.0
> WANTLIB += gio-2.0 glib-2.0 gobject-2.0 gtk-3 gtkspell3-3 harfbuzz icudata
> WANTLIB += icui18n icuuc intl lucene++ pango-1.0 pangocairo-1.0 pugixml
> -WANTLIB += wx_gtk3u_stc-3.0 wx_baseu-3.0 wx_baseu_net-3.0
> -WANTLIB += wx_baseu_xml-3.0 wx_gtk3u_adv-3.0 wx_gtk3u_core-3.0
> -WANTLIB += wx_gtk3u_html-3.0 wx_gtk3u_xrc-3.0
> +WANTLIB += wx_baseu-3.0 wx_baseu_net-3.0 wx_baseu_xml-3.0 wx_gtk3u_adv-3.0
> +WANTLIB += wx_gtk3u_core-3.0 wx_gtk3u_xrc-3.0 wx_gtk3u_webview-3.0
>
> +# C++14
> COMPILER= base-clang ports-gcc base-gcc
Please remove base-gcc, it cannot work with C++14 (also at least one
dependency uses cmake which also cannot build with base-gcc).
Otherwise this reads good, I will test and get back to you
