On Sat, Dec 18, 2021 at 12:11:31PM +0100, Omar Polo wrote: > Andrew Krasavin <[email protected]> writes: > > > On Sat, Dec 18, 2021 at 08:51:23AM +0300, Andrew Krasavin wrote: > >>Hello. > >> > >>This port is required for upcoming telegram-desktop port, that we > >>are currently working on with Klemens Nanni. > >> > >>Some things that still need to be done here: > >> > >>* there are problems with the macppc build > >>* the tests are currently turned off > >> > >>Otherwise it is a working port. > >> > >>To successfully build a port, you must also apply this patch: > >> > >>Index: sys/sys/exec_elf.h > >>=================================================================== > >>RCS file: /cvs/src/sys/sys/exec_elf.h,v > >>retrieving revision 1.93 > >>diff -u -p -r1.93 exec_elf.h > >>--- sys/sys/exec_elf.h 7 Dec 2021 22:17:03 -0000 1.93 > >>+++ sys/sys/exec_elf.h 17 Dec 2021 12:36:39 -0000 > >>@@ -725,6 +725,7 @@ struct elf_args { > >> #define CONCAT(x,y) __CONCAT(x,y) > >> #define ELFNAME(x) CONCAT(elf,CONCAT(ELFSIZE,CONCAT(_,x))) > >> #define ELFDEFNNAME(x) CONCAT(ELF,CONCAT(ELFSIZE,CONCAT(_,x))) > >>+#define ElfW(x) CONCAT(Elf,CONCAT(ELFSIZE,CONCAT(_,x))) > >> #endif > >> #if defined(ELFSIZE) && (ELFSIZE == 32) > >> > >>(Klemens has already sent the patch to tech@) > >> > >>I'll maintain the package. > >> > >>--- > >>Information for inst:abseil-cpp-20211102.0 > >> > >>Comment: > >>abseil common libraries (c++) > >> > >>Description: > >>Abseil is an open source collection of C++ libraries drawn from the > >>most fundamental pieces of Google's internal codebase. These > >>libraries are the nuts-and-bolts that underpin almost everything > >>Google runs. Bits and pieces of these APIs are embedded in most > >>of our open source projects, and Abseil aims to bring them together > >>into one comprehensive project. Abseil encompasses the most basic > >>building blocks of Google's codebase: code that is production-tested > >>and will be fully maintained for years to come. > >> > >>Maintainer: Andrew Krasavin <[email protected]> > >> > >>WWW: https://abseil.io/ > >>--- > >> > >>Feedback? OK? > >> > >> -- Wbr, Andrew Krasavin > > > > Update: > > > > Thanks to gkoehler@ kindly agreeing to test my port on macpp and > > powerpc, build for those platforms was fixed. > > > > For this, the patch patch-absl_base_internal_unscaledcycleclock_h > > was added (author - George Koehler - gkoehler@) and the patch > > patch-absl_debugging_internal_self_mem_image_h was edited > > (building vdso-related code is now simply disabled). > > > > Patch for sys/sys/exec_self.h that I mentioned in the last post is > > now also not necessary for a successful compilation. > > > > Once again I would like to thank George Koehler for his help. > > > > Updated port is in the attachment. Any feedback would be welcome. > > the port looks fine, and I'm interested in seeing telegram desktop > packaged too. > > I tried to enable the tests, but it's not easy. It needs a newer > version of devel/gtest (or rather, the latest commit or so, upstream > stopped tagging versions), then a tweak to disable lsan and even then it > fails a linking some tests > > ld: error: undefined symbol: > testing::Matcher<std::__1::basic_string_view<char, > std::__1::char_traits<char> > const&>::Matcher(char const*) > > so I'd add NO_TEST=Yes with a comment and forget about it :) > > Cheers, > > Omar Polo >
Newest version with whitespace nits, NO_TEST=yes comments and patch comments tweaked. FWIW, this builds and packages fine on amd64 base-clang 13.0.0 amd64 base-clang 11.1.0 amd64 ports-gcc 8.4.0 sparc64 base-clang 13.0.0 sparc64 ports-gcc 8.4.0 WIP net/tg_owt and net/tdesktop consumers also builds with it on amd64. Feedback? Objections? OK?
abseil-cpp.tgz
Description: Binary data
