Klemens Nanni <[email protected]> writes: > On Sat, Dec 18, 2021 at 12:11:31PM +0100, Omar Polo wrote: >> > [...] >> > Updated port is in the attachment. Any feedback would be welcome. >> >> the port looks fine, and I'm interested in seeing telegram desktop >> packaged too. >> >> I tried to enable the tests, but it's not easy. It needs a newer >> version of devel/gtest (or rather, the latest commit or so, upstream >> stopped tagging versions), then a tweak to disable lsan and even then it >> fails a linking some tests >> >> ld: error: undefined symbol: >> testing::Matcher<std::__1::basic_string_view<char, >> std::__1::char_traits<char> > const&>::Matcher(char const*) >> >> so I'd add NO_TEST=Yes with a comment and forget about it :) >> >> Cheers, >> >> Omar Polo >> > > Newest version with whitespace nits, NO_TEST=yes comments and patch > comments tweaked. > > FWIW, this builds and packages fine on > amd64 base-clang 13.0.0 > amd64 base-clang 11.1.0 > amd64 ports-gcc 8.4.0 > sparc64 base-clang 13.0.0 > sparc64 ports-gcc 8.4.0 > > WIP net/tg_owt and net/tdesktop consumers also builds with it on amd64. > > Feedback? Objections? OK?
OK op@ nitpick: in patch-abs_base_internal_unscaledcycleclock_h I think I'd be easier to read if defined(__powerpc__) || defined(__ppc__) was actually removed instead of commented out, it would stand out a bit more IMO, but I'm fine either the way. (I didn't know that you can put comments in the cpp conditionals, there's something new to learn every day :D) re tests: I'll send an update for gtests after ensuring existing consumers don't break as a first step.
