On 2022/05/22 01:37, Klemens Nanni wrote: > I had to neuter a few #ifdefs to avoid treating LibreSSL as too old > OpenSSL, e.g. wrt. some structs now being opaque: > > 9 -#if (OPENSSL_VERSION_NUMBER < 0x10100000L) || > defined(LIBRESSL_VERSION_NUMBER) > 10 +#if (OPENSSL_VERSION_NUMBER < 0x10100000L) || > defined(LIBRESSL_VERSION_NUMBER_TOO_OLD)
Not a real fan of the invented LIBRESSL_VERSION_NUMBER_TOO_OLD, it makes me wonder where/how this is defined. The usual thing to do in ports is either delete the LIBRESSL part or, if it was only added fairly recently (such that other projects using our patches might run into problems) add a version check. Other than that it's OK with me.
