On Sat, Jun 04, 2022 at 11:12:06AM +0100, Stuart Henderson wrote: > On 2022/05/22 01:37, Klemens Nanni wrote: > > I had to neuter a few #ifdefs to avoid treating LibreSSL as too old > > OpenSSL, e.g. wrt. some structs now being opaque: > > > > 9 -#if (OPENSSL_VERSION_NUMBER < 0x10100000L) || > > defined(LIBRESSL_VERSION_NUMBER) > > 10 +#if (OPENSSL_VERSION_NUMBER < 0x10100000L) || > > defined(LIBRESSL_VERSION_NUMBER_TOO_OLD) > > Not a real fan of the invented LIBRESSL_VERSION_NUMBER_TOO_OLD, > it makes me wonder where/how this is defined.
I can update the patches to just remove the line for now. > The usual thing to do in ports is either delete the LIBRESSL part or, > if it was only added fairly recently (such that other projects using > our patches might run into problems) add a version check. My plan was to do a proper version check and bring it upstream, but that's still on the TODO list. > Other than that it's OK with me. Thanks, I imported it earlier this day.
