On 2022/06/07 09:05, Stuart Cassoff wrote:
> Does it make sense to put all the TkInter bits inside .if
> ${BUILD_PACKAGES:M-tkinter} ?do you mean LIB_DEPENDS-tkinter, WANTLIB-tkinter, etc? if so, no, these should be set unconditionally > Are the changes to CHANGES.OpenBSD ok/necessary? changes patching the build files should be added, if it's just CONFIGURE_ARGS etc then I think not. I don't see a patch to match what you added to this? > I also noticed that Python 3.10 doesn't uninstall cleanly. any more info on that? > @so lib/python2.7/lib-dynload/datetime.so > @so lib/python2.7/lib-dynload/dbm.so > +@so lib/python2.7/lib-dynload/dl.so > @so lib/python2.7/lib-dynload/fcntl.so > @so lib/python2.7/lib-dynload/future_builtins.so > @so lib/python2.7/lib-dynload/grp.so > +@so lib/python2.7/lib-dynload/imageop.so > @so lib/python2.7/lib-dynload/itertools.so > @so lib/python2.7/lib-dynload/math.so > @so lib/python2.7/lib-dynload/mmap.so you added those to PLIST-main, shouldn't they be in PLIST-tkinter?
