Jeremie Courreges-Anglas wrote (2023-01-08 18:14 CET): > On Sun, Jan 08 2023, Omar Polo <o...@omarpolo.com> wrote: > > On 2023/01/08 16:25:16 +0100, Jérémie Courrèges-Anglas <j...@wxcvbn.org> > > wrote: > >> https://wxcvbn.org/~jca/build-failures/amd64-clang/2023-01-03/devel/fnc.txt > > > > fails building the bundled sqlite3 copy because of: > > > > : lib/sqlite3.c:57910:7: error: variable 'nUri' set but not used > > [-Werror,-Wunused-but-set-variable] > > : int nUri = 0; /* Number of URI parameters */ > > : ^ > > : 1 error generated. > > > > don't have the newer clang here yet but this should fix the build. > > > > ok? > > I would prefer us to have a clear list of which port is broken by which > warning before we start fixing them. I plan to go through the failures > this evening. > > Here the port uses -Werror, and -Wunused-but-set-variable is not a new > warning. I guess clang got better at this warning, I'm not sure we > should expect much fallout from it and I think it's probably best to > keep that one active as part of -Wall. But please wait until we have > the bigger picture. > > Thanks. :)
I think it's good practice to remove -Werror.
I had this patched out in fnc 0.4 and lost the patch later.
I'm for patching it out again.
ok sdk@
> > Index: patches/patch-fnc_bld_mk
> > ===================================================================
> > RCS file: patches/patch-fnc_bld_mk
> > diff -N patches/patch-fnc_bld_mk
> > --- /dev/null 1 Jan 1970 00:00:00 -0000
> > +++ patches/patch-fnc_bld_mk 8 Jan 2023 16:46:18 -0000
> > @@ -0,0 +1,29 @@
> > +drop -Werror
> > +
> > +Index: fnc.bld.mk
> > +--- fnc.bld.mk.orig
> > ++++ fnc.bld.mk
> > +@@ -11,7 +11,7 @@ HASH != cut -f 1 manifest.uuid
> > + DATE != sed '2q;d' manifest | cut -d ' ' -f 2 | tr T ' '
> > +
> > + # FLAGS NEEDED TO BUILD SQLITE3
> > +-SQLITE_CFLAGS = ${CFLAGS} -Wall -Werror -Wno-sign-compare -pedantic
> > -std=c99 \
> > ++SQLITE_CFLAGS = ${CFLAGS} -Wall -Wno-sign-compare -pedantic -std=c99 \
> > + -DNDEBUG=1 \
> > + -DSQLITE_DQS=0 \
> > + -DSQLITE_DEFAULT_MEMSTATUS=0 \
> > +@@ -37,12 +37,12 @@ SQLITE_CFLAGS = ${CFLAGS} -Wall -Werror
> > -Wno-sign-comp
> > + -DSQLITE_TRUSTED_SCHEMA=0
> > +
> > + # FLAGS NEEDED TO BUILD LIBFOSSIL
> > +-FOSSIL_CFLAGS = ${CFLAGS} -Wall -Werror -Wsign-compare -pedantic
> > -std=c99
> > ++FOSSIL_CFLAGS = ${CFLAGS} -Wall -Wsign-compare -pedantic -std=c99
> > +
> > + # On SOME Linux (e.g., Ubuntu 18.04.6), we have to include wchar curses
> > from
> > + # I/.../ncursesw, but linking to -lncursesw (w/ no special -L path) works
> > fine.
> > + # FLAGS NEEDED TO BUILD FNC
> > +-FNC_CFLAGS = ${CFLAGS} -Wall -Werror -Wsign-compare -pedantic
> > -std=c99 \
> > ++FNC_CFLAGS = ${CFLAGS} -Wall -Wsign-compare -pedantic -std=c99 \
> > + -I./lib -I./include -I/usr/include/ncursesw \
> > + -D_XOPEN_SOURCE_EXTENDED -DVERSION=${VERSION} -DHASH=${HASH} \
> > + -DDATE="${DATE}"
> >
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
signature.asc
Description: PGP signature
