On Fri, Aug 25, 2023 at 08:43:45PM +0100, Stuart Henderson wrote:
[...]
> Basically LGTM. Please avoid the old python-upstream-deprecated build
> things by replacing MODPY_SETUPTOOLS=Yes with MODPY_PYBUILD=setuptools
> and regen'ing plist, then it's ok with me.
Thanks, I committed it with these changes. If MODPY_SETUPTOOLS=Yes is
outdated, should Makefile.template be adjusted? Proposing diff below if
so...
> (I considered neutering the update check, but it only seems to run
> when explicitly selected from the menu, rather than automatically,
> so I think that's ok).
I didn't look into that... I'll see if I find anything concerning about
those checks.
Index: Makefile.template
===================================================================
RCS file: /cvs/ports/infrastructure/templates/Makefile.template,v
retrieving revision 1.94
diff -u -p -r1.94 Makefile.template
--- Makefile.template 28 Apr 2023 22:06:56 -0000 1.94
+++ Makefile.template 25 Aug 2023 20:24:44 -0000
@@ -128,7 +128,7 @@ MASTER_SITES = ???
#
# Get source from pypi.org
#MODPY_PI = Yes
-#MODPY_SETUPTOOLS = Yes
+#MODPY_PYBUILD = setuptools
# If port is python2 only
#MODPY_VERSION = ${MODPY_DEFAULT_VERSION_2}
# If port is a Python module (py-*) that is or might be used by other Python
