On 2023/08/25 16:26, Thomas Frohwein wrote:
> On Fri, Aug 25, 2023 at 08:43:45PM +0100, Stuart Henderson wrote:
> [...]
> > Basically LGTM. Please avoid the old python-upstream-deprecated build
> > things by replacing MODPY_SETUPTOOLS=Yes with MODPY_PYBUILD=setuptools
> > and regen'ing plist, then it's ok with me.
>
> Thanks, I committed it with these changes. If MODPY_SETUPTOOLS=Yes is
> outdated, should Makefile.template be adjusted? Proposing diff below if
> so...
> #
> # Get source from pypi.org
> #MODPY_PI = Yes
> -#MODPY_SETUPTOOLS = Yes
> +#MODPY_PYBUILD = setuptools
Ah yes, probably a good idea. Maybe mention some of the other build
backends with a pointer to the manual for others?
#MODPY_PYBUILD = setuptools
# or flit_core, hatchling, etc - see port-modules(5)
> # If port is python2 only
> #MODPY_VERSION = ${MODPY_DEFAULT_VERSION_2}
I think we could remove that from Makefile.template now, hopefully not
needed for any new ports.
