On 2023/10/20 11:53, Ian Darwin wrote:
> Thanks for picking this up and finishing it!
> I'm OK with your being opencascade maintainer.
>
> I built the opencascade and prusaslicer 2.5.2p1 and that seems to work as
> before. Didn't test kicad but it's a trivial change and you've tested it. So
> those three are OK ian@.
>
> You probably need a 'quirks' entry and/or a conflict marker for anyone who
> might have the older oce installed. Probably a conflict entry, and then
> remove the old one in a few days?
Yes, it needs a quirks entry in $stem_extensions, @conflict oce-* in PLIST,
and unhook and remove cad/oce whenever this gets committed. The version
number is higher than that of oce so that should be enough.
: WANTLIB += ${COMPILER_LIBCXX} GL X11 c execinfo fontconfig freetype
: WANTLIB += m tcl86 tk86
should use ${MODTK_WANTLIB} instead of tcl86 tk86 (as already done in
cad/oce).
: .for LIB in TKBO TKBRep TKBin TKBinL TKBinTObj TKBinXCAF TKBool \
: TKCAF TKCDF TKDCAF TKDraw TKExpress TKFeat TKFillet TKG2d \
: TKG3d TKGeomAlgo TKGeomBase TKHLR TKIGES TKLCAF TKMath \
: TKMesh TKMeshVS TKOffset TKOpenGl TKOpenGlTest TKPrim \
: TKQADraw TKRWMesh TKSTEP TKSTEP209 TKSTEPAttr TKSTEPBase \
: TKSTL TKService TKShHealing TKStd TKStdL TKTObj TKTObjDRAW \
: TKTopAlgo TKTopTest TKV3d TKVCAF TKVRML TKViewerTest TKXCAF \
: TKXDE TKXDECascade TKXDEDRAW TKXDEIGES TKXDESTEP TKXMesh \
: TKXSBase TKXSDRAW TKXml TKXmlL TKXmlTObj TKXmlXCAF TKernel
: SHARED_LIBS += ${LIB} 0.0
: .endfor
These should use the same (if compatible ABI) or higher (if not or
if unknown) library version number than oce, so it probably wants 2.0
Otherwise reads OK to me but I've not tested.
