On 2023/10/21 12:33, Johannes Thyssen Tishman wrote:
> Thanks ian@ and sthen@ for your feedback. I've updated the port
> based on your feedback. Please find attached the updated port, a
> patch for devel/quirks with the new entry in @stem_extensions and
> the same patches for prusaslicer and kicad that I sent before.
>
> @sthen: Regarding the version bump for the SHARED_LIBS, I just
> followed the instructions here[1] and looked for differences between
> the shared libraries in the two packages as follows:
In this case, because the pkgpath changes too, there's no advantage to
_not_ bumping major, so best to just do that.
In other cases, this script helps:
------
#!/bin/ksh
# Usage: env FLAVOR=... chksym
set -e
set -A libs -- $(make print-plist-all-libs)
[[ -f $(make show=_FAKE_COOKIE) ]] || {
print -u2 'run "make fake" first'
exit 1
}
obj=$(make show=WRKINST)
for _l in "${libs[@]}"; do
lib=${_l##*/}
lib=${lib%.so.*}
old=$(ls -rt ${_l%.so.*}.so.* | tail -1)
newver=$(make show=LIB${lib#lib}_VERSION)
new=${obj}/${_l%.so*}.so.${newver}
/usr/src/lib/check_sym "${old}" "${new}"
done
------
It reuses a tool meant for checking changes in base libraries.
For the purposes of ports, usually look at "Dynamic export changes";
- added functions means that at least a minor bump is needed
- removed functions mean that a major bump is needed
however it does not cover everything - if parameters to an exported
function change their types, a major bump may still be needed even
if this doesn't report any change.
Another good source of information is diffing old and new installed
headers.
Updated diff is OK with me
