Stefan Sperling [2008-11-30, 15:19:38]:
> Hello,
>
> the diff below splits extra and user-contributed scripts and tools out
> of the -main package into separate -tools and -contrib packages.
...
> The stuff in -tools is maintained by the Subversion project itself,
> and has the same copyright holder and license.
First question, is it necessary to package this separately from -main ?
> The stuff in -contrib may have different licenses and copyright holders
> than Subversion proper.
Have you checked whether those licenses allow us to redistribute it?
> One quirk:
> The -tools subpackages has redundant libs, which show up during
> 'make lib-depends-check:
>
> /usr/ports/packages/i386/all/subversion-tools-1.5.4.tgz:
> Extra: svn_client-1.1
> Extra: svn_diff-1.1
> Extra: svn_ra-1.1
> Extra: svn_ra_local-1.1
> Extra: svn_ra_neon-1.1
> Extra: svn_ra_svn-1.1
> Extra: svn_wc-1.1
>
> Without those extra deps, it does not properly depend on the -main package,
> and trying to install it without having the -main package installed
> fails like this:
>
> /usr/ports/packages/i386/al
> $ env SUBPACKAGE=-tools make install
> ===> Verifying specs: svn_delta-1.>=1.1 svn_fs-1.>=1.1 svn_fs_base-1.>=1.1
> svn_fs_fs-1.>=1.1 svn_fs_util-1.>=1.1 svn_repos-1.>=1.1 svn_subr-1.>=1.1
> expat db z apr-1 aprutil-1 c iconv intl
> Missing library for svn_delta-1.>=1.1
> Missing library for svn_fs-1.>=1.1
> Missing library for svn_fs_base-1.>=1.1
> Missing library for svn_fs_fs-1.>=1.1
> Missing library for svn_fs_util-1.>=1.1
> Missing library for svn_repos-1.>=1.1
> Missing library for svn_subr-1.>=1.1
> Fatal error
> *** Error code 1
>
> I'd expect the dependency handling to work without the extra libs,
> but this does not seem to be the case... no idea where the problem is.
do the tools require the libraries or not? if they do, then you will need
the main package to be installed.
> To reproduce, change these lines in the Makefile:
>
> . for _lib in ${SVN_LIBS}
> LIB_DEPENDS-tools+= ${_lib}.>=${SO_VERSION}:${PKGNAME}:${BUILD_PKGPATH}
> . endfor
>
> to this:
>
> . for _lib in svn_delta-1 svn_fs-1 svn_fs_base-1 svn_fs_fs-1 \
> svn_fs_util-1 svn_repos-1 svn_subr-1
> LIB_DEPENDS-tools+= ${_lib}.>=${SO_VERSION}:${PKGNAME}:${BUILD_PKGPATH}
> . endfor
>
> This change causes lib-depends check to be happy, but the dependency
> of -tools on -main to fail.
haven't tried it, but maybe try devel/subversion,-main instead of
just BUILD_PKGPATH?
> -PSEUDO_FLAVORS= no_bindings no_ap2
> +PSEUDO_FLAVORS= no_bindings no_ap2 no_contrib no_tools
I don't think this requires extra pseudo flavors? It doesn't seem to pull in
a great load of extra dependencies at build time.
