On Mon, Jan 12, 2009 at 09:55:32PM +0100, Jonathan Schleifer wrote:
> >No, it isn't. There may be errors in the Makefile. There may be
> >overrides in the environment and/or command line that may *not*
> >work as desired which you can't check by just looking at the Makefile.
>
> Have you actually looked at the Makefile and buildsys.mk.in?
To be honest: no, because I'm not involved in mowgli (nor in mcs).
And I didn't want to argue about this specific software (nor to
blame it our you) -- I'm arguing about too silent Makefiles in
general.
>From my point of view (as a porter), Makefiles hiding details, or
Makefiles I have to look at before I can be sure that they don't
lie, are just additional work. And hiding details doesn't give
anyone anything IMHO.
During the last two weeks, I've seen at least one project with a
Makefile hiding details and producing fancy output and actually
*not* applying CFLAGS correctly in all targets. Unfortunately, I
don't remember which project it was (none of yours, maybe something
from suckless.org).
And there are even worse examples, like this Cabal thingy used in
the Haskell world.
> You'll see that the environment can't override it. And you'll see
> that there's a bug in the buildsys if the flags from the Makefile
> are not used. And that'd be something for me to fix then, and
> that'd be a case to disable .SILENT.
If I've to review a port with a too quiet Makefile and if it takes
more just five minutes to make it less quiet, I usually just remove
the port submission from my inbox without any further comment.
Ciao,
Kili
