On Tue, Jan 12, 2010 at 8:55 PM, Landry Breuil <[email protected]> wrote: > On Tue, Jan 12, 2010 at 11:56:27AM +0100, Auclair Vincent wrote: >> Update version from 2.2.0 to 2.3.0 >> >> Tarball is attached. > > Comments portswise : > > - SHARED_LIBS usually start at 0.0 > - as CONFIGURE_STYLE is set to gnu, automake won't be run, so > *Makefile.am won't be read, so patching them is useless. > patches/patch-src_Makefile_am and patches/patch-Makefile_am can go away. > regress fails with: > gmake[3]: *** No rule to make target `/usr/local/libgtest.la', needed by > `protobuf-test'. Stop. > -> your patch-src_Makefile_in is are wrong. (missing /lib/ after > ${LOCALBASE} for libgtest*.la.) > > Other than that, looks good. Builds fine @amd64/ppc.
Updated tarball which corrects the problems -- Vincent Auclair - auclair.vincent[ at ]gmail.com (+33) 6 80 77 59 67
protobuf.tar.gz
Description: GNU Zip compressed data
