On Fri, 16 Apr 2010, Edd Barrett wrote:
> Hi,
Ciao!
> Here is a much needed update to tint2.
Nice.
> * Hacked the battery code to map to OpenBSD. Works fine.
Isn't more elegant to protect code with
#if defined(__OpenBSD__)
...
#else
...
#endif
Instead of using #if 0/#endif ?
> * Can someone check lib-depends-check on their system. I find it odd that I
> have to add -lX11 to the environment for the build to work, but then it is
> not needed in WANTLIB. Hmmm
Imho this is better:
--- Makefile Fri Apr 16 08:50:20 2010
+++ /root/Makefile Fri Apr 16 08:31:09 2010
@@ -15,8 +15,8 @@
PERMIT_DISTFILES_CDROM= Yes
PERMIT_DISTFILES_FTP= Yes
-WANTLIB= Xinerama Xrender c cairo glib-2.0 gobject-2.0 \
- Xcomposite Xdamage
+WANTLIB= X11 Xinerama Xrender c cairo glib-2.0 \
+ gobject-2.0 Xcomposite Xdamage
MASTER_SITES= http://tint2.googlecode.com/files/
@@ -28,7 +28,7 @@
NO_REGRESS= Yes
CONFIGURE_STYLE=gnu
-CONFIGURE_ENV+= "LDFLAGS=-L${PREFIX}/lib -L${X11BASE}/lib -lX11"
+CONFIGURE_ENV+= "LDFLAGS=-L${PREFIX}/lib -L${X11BASE}/lib"
# set up for @sample in PLIST
post-install:
All other bits look fine to me.
Cheers,
David
