On 2010/04/19 21:35, Ian McWilliam wrote:
>
> On 19/04/2010, at 8:55 PM, Stuart Henderson wrote:
>
> > On 2010/04/18 19:52, Brad wrote:
> >> On Sunday 18 April 2010 18:46:08 Ian McWilliam wrote:
> >>> On 19/04/2010 6:01 AM, Stuart Henderson wrote:
> >>>> On 2010/04/18 17:48, Sebastian Liem wrote:
> >>>>> Landry wrote:
> >>>>>> On Sun, Apr 18, 2010 at 02:47:42PM +0200, Sebastian Liem wrote:
> >>>>>>> I used MAKE_FLAGS instead of patching the Makefile is that ok?
> >>>>>>
> >>>>>> Yes if it works, but you still need SHARED_LIBS in port Makefile so
> >>>>>> that the shared lib is correctly registered in PLIST and in package db.
> >>>>>
> >>>>> Done. New version is attached.
> >>>>>
> >>>>>>> Stuart wrote:
> >>>>>>>> This is going to cause problems with the samba update.
> >>>>>>>
> >>>>>>> Howcome? I didn't see samba installing any shared libs and
> >>>>>>> I could build net/samba without problems. What's "the samba update".
> >>>>>>
> >>>>>> It's the update to 3.4.x (or 3.5.x) floating around in ports@ ml
> >>>>>> archive, which should soon replace the outdated version we have
> >>>>>> in-tree.
> >>>>>
> >>>>> Ah, I see. Can't samba build depend on talloc and not build it itself?
> >>>>
> >>>> I think considering where libtalloc comes from, it seems to make more
> >>>> sense to have it built by the samba port, possibly placed into a
> >>>> subpackage so something needing talloc can pull in just that package
> >>>> rather than the whole of samba.
> >>>>
> >>>> There are a couple of relatively small things that need doing to get
> >>>> the 3.5.1 port ready (if anyone knows how to get CONFIGURE_STYLE=autoconf
> >>>> working with it, that would be handy..) also Ian has been looking at
> >>>> 3.5.2 and trying to get around more of the "all the world's linux"
> >>>> problems that keep cropping up.
> >>>
> >>> Forget trying to get CONFIGURE_STYLE=autoconf working with the samba
> >>> port. The samba guys have left out m4 macro files which are referenced
> >>> by the configure cruft and it'll become patch hell to make it all work.
> >>> I wish I could work out the voodoo magic involved between samba 3.5.x
> >>> releases.
> >>>
> >>> Ian McWilliam
> >>
> >> Then get the Makefile fixed upstream so a proper distfile will be rolled
> >> with
> >> the missing m4 macro files.
> >
> > Upstream's distfile is ok.
> >
>
> 3.5.1 or 3.5.2?
>
> 3.5.2 starts out with
>
> # configuration script generated by Autoconf, you may include it under
> generated by GNU Autoconf 2.63. Invocation command line was
> configured by $0, generated by GNU Autoconf 2.63,
> Running autoconf-2.61 in /usr/ports/pobj/samba-3.5.2/samba-3.5.2/source3
> m4: configure.in at line 23: include(pkg.m4): No such file or directory
> autom4te-2.61: /usr/bin/m4 failed with exit status: 1
>
> and digging further there are other things missing.
CONFIGURE_STYLE=autoconf doesn't set the paths correctly; this does:
BUILD_DEPENDS= ${MODGNU_AUTOCONF_DEPENDS}
CONFIGURE_STYLE= gnu
AUTOCONF_VERSION= 2.63
post-patch:
cd ${WRKSRC}; \
AUTOCONF_VERSION=${AUTOCONF_VERSION} \
./autogen.sh
