On Wed, Nov 03, 2010 at 09:43:17AM +0100, Antoine Jacoutot wrote: > On Wed, 3 Nov 2010, Stuart Henderson wrote: > > > On 2010/11/03 00:19, Antoine Jacoutot wrote: > > > On Tue, 2 Nov 2010, Steven Mestdagh wrote: > > > > > > > Marc Espie [2010-10-31, 12:26:43]: > > > > > I finally made up my mind about it. Those are the rules. Don't commit > > > > > new > > > > > ports without proper spacing. Whenever you update ports, if you have > > > > > the > > > > > time, please add the spacing. > > > > > > > > I don't have a problem with this, but I notice people send in diffs > > > > which > > > > mix updates with spacing, and a simple update diff quickly becomes > > > > really > > > > long and harder to read. So I suggest we don't intermix this too much. > > > > > > I cannot agree more. Stop the madness please. > > > > Absolutely. I would suggest also that we don't do this port by port. > > If we have to do this I think the usual method of changing a category > > at a time is the only sane way, we really don't want hundreds of > > "space conversion" diffs for individual ports cluttering po...@. > > I think it should be up to the people maintaining the port. This space > thing is just unreadable to me. As right as it may be, it looks just > wrong to my eyes and makes thel bleed...
Fix your eyes, seriously. It's a case of habit. I used to see VAR=value as more natural. But the bad consequences made me change that habit, and now I have absolutely no problem with the new style. Like I said, it's not an aesthetic choice. We're talking trappings of Makefile semantics, and avoidance of possible problems. If I do change your ports, I will add spaces.
