On Thu, Nov 04, 2010 at 11:31:51PM +0100, Landry Breuil wrote:
> On Thu, Nov 04, 2010 at 02:09:38PM +0100, Landry Breuil wrote:
> > On Thu, Nov 04, 2010 at 02:04:24PM +0100, Landry Breuil wrote:
> > > On Thu, Nov 04, 2010 at 01:42:01PM +0100, Landry Breuil wrote:
> > > > On Wed, Nov 03, 2010 at 08:17:05AM +0100, Jasper Lievisse Adriaanse
> > > > wrote:
> > > > > On Sun, Oct 31, 2010 at 12:33:46PM +0100, Marc Espie wrote:
> > > > > > On Mon, Oct 25, 2010 at 11:27:25PM +0200, Tobias Ulmer wrote:
> > > > > > > Hi Marc,
> > > > > > >
> > > > > > > metaauto should IMHO return an error code instead of failing
> > > > > > > silently.
> > > > > > >
> > > > > > We've now tested this in a bulk buil. It doesn't quite work, so it
> > > > > > won't
> > > > > > go in until errors in the corresponding ports are fixed... ;-(
> > > > > which ports are those?
> > > >
> > > > with the diff, automake 1.10 breaks with :
> > > > checking whether autoconf is installed... no
> > > > configure: error: Autoconf 2.60 or better is required.
> > > > Please make sure it is installed and in your PATH.
> > > >
> > > > automake 1.9 breaks with :
> > > > checking whether autoconf is installed... no
> > > > configure: error: Autoconf 2.58 or better is required.
> > > > Please make sure it is installed and in your PATH.
> > > >
> > > > and iirc other automake ports fails too.
> > > >
> > > > so i think build_depends for those ports should be adjusted, but i have
> > > > no idea how it is related to the metaauto diff itself.
> > >
> > > Actually it's simpler than that, and automake 1.8 breaks too :
> > >
> > > configure does:
> > >
> > > configure:1825: eval autoconf --version
> > > Provide an AUTOCONF_VERSION environment variable, please
> > > configure:1828: $? = 127
> > >
> > > So, automake ports should build_depends on the needed version of
> > > autoconf, and CONFIGURE_ENV+= AUTOCONF_VERSION=${AUTOCONF_VERSION}
> > > should be added too.
> >
> > print/cups breaks too:
> >
> > ===> Configuring for cups-1.4.4p6
> > cd /usr/obj/ports//cups-1.4.4/cups-1.4.4 && AUTOMAKE_VERSION=1.9 aclocal
> > -I config-scripts
> > Provide an AUTOCONF_VERSION environment variable, please
> > aclocal-1.9: autom4te failed with exit status: 127
> >
> > - cd ${WRKSRC} && AUTOMAKE_VERSION=${AUTOMAKE_VERSION} aclocal -I
> > config-scripts
> > - cd ${WRKSRC} && AUTOCONF_VERSION=${AUTOCONF_VERSION} autoconf -I
> > config-scripts
> > + cd ${WRKSRC} && AUTOMAKE_VERSION=${AUTOMAKE_VERSION}
> > AUTOCONF_VERSION=${AUTOCONF_VERSION} aclocal -I config-scripts
> > + cd ${WRKSRC} && AUTOMAKE_VERSION=${AUTOMAKE_VERSION}
> > AUTOCONF_VERSION=${AUTOCONF_VERSION} autoconf -I config-scripts
> >
>
> audio/tremor-tools:
> ===> Building for tremor-tools-1.0p4
> cd . && aclocal
> Provide an AUTOMAKE_VERSION environment variable, please
> gmake: *** [aclocal.m4] Error 127
>
> There, you got you full breakage list, cups, automake*, and freetds
> which is already fixed :)
Here's the diff for automake* i have in my tree, i'd like a doublecheck.
freetds and cups are fixed, i have no idea for tremor-tools. After that,
i'm ok with metaauto diff.
Landry
Index: 1.10/Makefile
===================================================================
RCS file: /cvs/ports/devel/automake/1.10/Makefile,v
retrieving revision 1.3
diff -u -r1.3 Makefile
--- 1.10/Makefile 30 Aug 2010 22:09:45 -0000 1.3
+++ 1.10/Makefile 5 Nov 2010 08:21:22 -0000
@@ -25,12 +25,14 @@
AUTOCONF_VERSION= 2.60
AUTOCONF_REGRESS= 2.65
-BUILD_DEPENDS= ::devel/metaauto
+BUILD_DEPENDS= ${RUN_DEPENDS}
RUN_DEPENDS= ${MODGNU_AUTOCONF_DEPENDS}
SUFFIX= -${VERSION}
CONFIGURE_STYLE= gnu
CONFIGURE_ARGS= --infodir=${PREFIX}/info
+CONFIGURE_ENV+= AUTOCONF_VERSION=${AUTOCONF_VERSION}
+
MAKE_FLAGS+= pkgvdatadir=${PREFIX}/share/automake${SUFFIX} \
APIVERSION=${VERSION}
SUBST_VARS= SUFFIX
Index: 1.8/Makefile
===================================================================
RCS file: /cvs/ports/devel/automake/1.8/Makefile,v
retrieving revision 1.8
diff -u -r1.8 Makefile
--- 1.8/Makefile 22 Jul 2010 12:13:17 -0000 1.8
+++ 1.8/Makefile 5 Nov 2010 08:21:22 -0000
@@ -19,11 +19,12 @@
AUTOCONF_VERSION= 2.59
-BUILD_DEPENDS= ::devel/metaauto
+BUILD_DEPENDS= ${RUN_DEPENDS}
RUN_DEPENDS= ${MODGNU_AUTOCONF_DEPENDS}
SUFFIX= -${VERSION}
CONFIGURE_STYLE= gnu
+CONFIGURE_ENV+= AUTOCONF_VERSION=${AUTOCONF_VERSION}
MAKE_FLAGS+= MAKEINFO="makeinfo --no-split" \
pkgvdatadir=${PREFIX}/share/automake${SUFFIX} \
APIVERSION=${VERSION}
Index: 1.9/Makefile
===================================================================
RCS file: /cvs/ports/devel/automake/1.9/Makefile,v
retrieving revision 1.14
diff -u -r1.14 Makefile
--- 1.9/Makefile 30 Sep 2010 15:51:54 -0000 1.14
+++ 1.9/Makefile 5 Nov 2010 08:21:22 -0000
@@ -24,11 +24,14 @@
AUTOCONF_VERSION= 2.59
-BUILD_DEPENDS= ::devel/metaauto
+BUILD_DEPENDS= ${RUN_DEPENDS}
RUN_DEPENDS= ${MODGNU_AUTOCONF_DEPENDS}
SUFFIX= -${VERSION}
CONFIGURE_STYLE= gnu
+MAKE_ENV+= AUTOCONF_VERSION=${AUTOCONF_VERSION}
+CONFIGURE_ENV+= AUTOCONF_VERSION=${AUTOCONF_VERSION}
+
CONFIGURE_ARGS= --infodir=${PREFIX}/info
MAKE_FLAGS+= pkgvdatadir=${PREFIX}/share/automake${SUFFIX} \
APIVERSION=${VERSION}
