On 2011/09/06 00:20, Vadim Zhukov wrote:
> 2011/9/5 Vadim Zhukov <[email protected]>:
> > 2011/9/5 Stuart Henderson <[email protected]>:
> >> On 2011-09-05, Vadim Zhukov <[email protected]> wrote:
> >>> Hello all.
> >>>
> >>> Those patches allow C++ programs that include libmms headers to compile.
> >>> This is needed in particular for upcoming KDE update. Patches will be
> >>> sent upstream too, of course.
> >>
> >> wouldn't it make more sense to just remove the variable names from the 
> >> prototypes?
> >
> > I thought so, but other functions will still have names, so upstream
> > may dislike them for style.
> > Anyway, they're harmless, and personally I don't care for this code.
> > I can totally remove all names if you wish. :)
> 
> Just checked (should done this before posting, of course): upstream
> already renamed problematic names. So we could just drop patches above
> when port get updated.

In this case you should take the diff from upstream instead, or
just update the port as long as gstreamer-plugins-bad is still ok
with it.

Reply via email to