On Mon, Sep 05, 2011 at 04:21:52PM -0400, Brad wrote:
> On 05/09/11 3:23 PM, Vadim Zhukov wrote:
> >2011/9/5 Stuart Henderson<[email protected]>:
> >>On 2011-09-05, Vadim Zhukov<[email protected]>  wrote:
> >>>Hello all.
> >>>
> >>>Those patches allow C++ programs that include libmms headers to compile.
> >>>This is needed in particular for upcoming KDE update. Patches will be
> >>>sent upstream too, of course.
> >>
> >>wouldn't it make more sense to just remove the variable names from the 
> >>prototypes?
> >
> >I thought so, but other functions will still have names, so upstream
> >may dislike them for style.
> 
> Stop talking about upstream when its pretty clear you didn't even
> bother checking the upstream src repo before making the patch.

Hey, brad.

Try to avoid making unfriendly comments to contributors.

Remember you don't speak for the project ?

Reply via email to