On 2012/02/02 13:24, Jeremy C. Reed wrote: > On Thu, 2 Feb 2012, Stuart Henderson wrote: > > > Hmm. Try USE_LIBTOOL=gnu and see if there's a change. > > No change. > > On Thu, 2 Feb 2012, Kirill Bychkov wrote: > > I have the same error when compiling TORCS on amd64. Adding -fPIC to > > TORCS port doesn't help, but adding CFLAGS+=-fPIC to devel/plib solves > > this problem. So... may be some of depends are missing -fPIC? > > I added to my port's makefile: > CXXFLAGS+= -fPIC > > And that fixed the build of the other software using it. > > Thanks for the hint. I still don't know yet what ports did to make the > change. > > Anyways, anyone have comments on the porting itself? (tarball in first > message.) >
Yes but only minor; please start SHARED_LIBS from 0.0 rather than using upstream's versioning, and there's a minor whitespace nit in MASTER_SITES, otherwise looks good to me. With those changes I would be ok with this going in after we're done with lock for 5.1.
