Hello.

I was looking at the rss2email port at

  http://www.openbsd.org/cgi-bin/cvsweb/ports/mail/rss2email

and noticed a few things:

1. The Makefile refers to version 2.70, but the latest version of
   rss2email is 2.71.  (I know, a port can't always be on the latest
   version, but since this was just added two months ago, it seems nice
   if it could start out on the latest version.)

2. The Makefile has:

     SUBST_VARS+=  MODPY_SITEPKG

   but files/r2e contains two variables: MODPY_BIN and MODPY_SITEPKG.  I
   don't know a lot about OpenBSD ports, but wouldn't you need to list
   MODPY_BIN in SUBST_VARS in the Makefile for it to get substituted
   correctly when installing files/r2e?

3. In files/r2e, the last argument of the exec is

     $*

   but normally the correct thing to use is

     "$@"

   which will preserve spaces in an argument and not split such an
   argument into multiple arguments.

Thanks,

Lewis

Reply via email to