On 2013/08/29 15:42, J. Lewis Muir wrote: > Hello. > > I was looking at the rss2email port at > > http://www.openbsd.org/cgi-bin/cvsweb/ports/mail/rss2email > > and noticed a few things: > > 1. The Makefile refers to version 2.70, but the latest version of > rss2email is 2.71. (I know, a port can't always be on the latest > version, but since this was just added two months ago, it seems nice > if it could start out on the latest version.)
Actually the latest version is 3.5, https://pypi.python.org/pypi/rss2email/ but it needs a bit more work, including tweaks to the libraries it uses so they are built for python3. > 2. The Makefile has: > > SUBST_VARS+= MODPY_SITEPKG > > but files/r2e contains two variables: MODPY_BIN and MODPY_SITEPKG. I > don't know a lot about OpenBSD ports, but wouldn't you need to list > MODPY_BIN in SUBST_VARS in the Makefile for it to get substituted > correctly when installing files/r2e? Adding this is handled by the python module, see port-modules(5) $ make show=SUBST_VARS MODPY_PYCACHE MODPY_COMMENT MODPY_PYC_MAGIC_TAG MODPY_BIN MODPY_EGG_VERSION MODPY_VERSION MODPY_BIN_SUFFIX MODPY_PY_PREFIX MODPY_SITEPKG MACHINE_ARCH ARCH HOMEPAGE ^PREFIX ^SYSCONFDIR FLAVOR_EXT FULLPKGNAME MAINTAINER ^BASE_PKGPATH ^LOCALBASE ^X11BASE ^TRUEPREFIX ^RCDIR > 3. In files/r2e, the last argument of the exec is > > $* > > but normally the correct thing to use is > > "$@" > > which will preserve spaces in an argument and not split such an > argument into multiple arguments. I don't think it makes a lot of difference in this case (afaict it would only cause a problem if you use opmlimport with a filename containing spaces) though it does make sense to fix this next time the port is updated. > Thanks, > > Lewis >
