On 10/29/2013 12:01 AM, Kent R. Spillner wrote:
yes, pkg/README is not a place to copy upstream's README (maybe it makes sense
to install that into /usr/local/share/doc/vit via post-install/do-install)
it's for OpenBSD-specific information and should be based on the template
in ports/infrastructure/templates/README.template.
Attached is a new version incorporating Brian's feedback. After reviewing the README I
decided the "features list" doesn't add much, so I decided not to roll it into
pkg/DESCR. I am installing it into /usr/local/share/doc/vit, though.
Just some nitpicks:
Not quite with the @sample.
vit-commands is supposed to live in /etc, right? Then it should look
like this:
share/vit/vit-commands
@sample ${SYSCONFDIR}/vit-commands
(this ensures that you never replace or modify existing files in /etc
and that vit-commands will end up in the package - see point 14 of the
ports checklist I linked to in my previous email)
While it's not wrong, I think I'd prefer the first line of the
do-install use WRKSRC instead of WRKBUILD; for consistency if nothing else.
Besides that, it looks good to me and seems to work from my (admittedly
light) testing - caveat from your first mail heeded - perhaps that
should be added to the README if not resolved in a timely manner.
~Brian
