On 1/3/2014 2:42 AM, Ted Roby wrote:
This updates net/tintin++ to 2.01.0.
Lots of new features added since the currently
outdated version. Software is now GPLv2+.
WANTLIB includes pcre.

patch-Makefile_in adds ${LOCALBASE}/include to INCS


Why not use MAKE_FLAGS=INCS=-I${LOCALBASE}/include? Then all the patches go away.

More stuff below.



Index: Makefile
===================================================================
RCS file: /cvs/ports/net/tintin++/Makefile,v
retrieving revision 1.18
diff -u -p -r1.18 Makefile
--- Makefile    10 Dec 2013 23:42:29 -0000      1.18
+++ Makefile    3 Jan 2014 07:17:16 -0000
@@ -2,28 +2,29 @@

  COMMENT=      client program to help playing muds

-DISTNAME=       tintin++v1.5pl6
-PKGNAME=       tintin-1.5.6
-REVISION=      1
+DISTNAME=       tintin-2.01.0
+PKGNAME=       tintin-2.01.0

If DISTNAME = PKGNAME, don't need PKGNAME.

+REVISION=      0

REVISION goes away when version number is bumped.

  CATEGORIES=     net games


No HOMEPAGE?
No MAINTAINER? Do you want to be MAINTAINER?

-MASTER_SITES=  http://ftp.kiae.su/pub/unix/games/
-EXTRACT_SUFX=   .tar.Z
+MASTER_SITES=  ${MASTER_SITE_SOURCEFORGE:=tintin/}

-# Public Domain
+# GPLv2+
  PERMIT_PACKAGE_CDROM= Yes

-WANTLIB += c
+CONFIGURE_ENV=  CPPFLAGS="-I${LOCALBASE}/include" \
+                LDFLAGS="-L${LOCALBASE}/lib"

-CONFIGURE_STYLE=       gnu old
+LIB_DEPENDS= devel/pcre

-WRKDIST=       ${WRKDIR}/tintin++/src
+WANTLIB +=              pcre

You need to run 'make port-lib-depends-check' - you're missing WANTLIB entries.

+CONFIGURE_STYLE=        gnu
+
+WRKDIST=       ${WRKDIR}/tt/src

  NO_TEST=      Yes

  do-install:

Should some of the documentation in ${WRKSRC}/../docs/ be included? tintin19.txt looks like it could be useful.

-       ${INSTALL_DATA_DIR} ${PREFIX}/lib/tintin
        ${INSTALL_PROGRAM} ${WRKSRC}/tt++ ${PREFIX}/bin
-       ${INSTALL_DATA} ${WRKSRC}/support/.tt_help.txt.Z ${PREFIX}/lib/tintin

  .include <bsd.port.mk>

Could you please look through Makefile.template and rearrange variables accordingly?

~Brian

PS - Vadim: 'portcheck -CU' throws a bogus "trailing whitespace in Makefile" - I can send you the Makefile that threw it (which is a modified version of the diff being discussed here).

Reply via email to