On 1/4/2014 12:17 AM, Ted Roby wrote:
On Fri, Jan 03, 2014 at 04:12:25AM -0500, Brian Callahan wrote:
On 1/3/2014 2:42 AM, Ted Roby wrote:
This updates net/tintin++ to 2.01.0.
Lots of new features added since the currently
outdated version. Software is now GPLv2+.
WANTLIB includes pcre.
patch-Makefile_in adds ${LOCALBASE}/include to INCS
Why not use MAKE_FLAGS=3DINCS=3D-I${LOCALBASE}/include? Then all the
patches go away.
More stuff below.
Thank you for all the feedback. I reviewed the Makefile.template and
perused the Porter's Handbook again. I also contacted the developer
and let him know of my efforts. I am interested in maintaining this
port, and included my address in this version just in case.
This time around it feels like less hack and more progress.
Two minor nits, neither of which I think require you to resubmit this.
I'm ok with this, if someone wants to give me an ok to commit.
Index: Makefile
===================================================================
RCS file: /cvs/ports/net/tintin++/Makefile,v
retrieving revision 1.18
diff -u -p -r1.18 Makefile
--- Makefile 10 Dec 2013 23:42:29 -0000 1.18
+++ Makefile 4 Jan 2014 04:49:40 -0000
@@ -1,29 +1,39 @@
# $OpenBSD: Makefile,v 1.18 2013/12/10 23:42:29 jca Exp $
-COMMENT= client program to help playing muds
+COMMENT= client program for playing muds with advanced features
+
+DISTNAME= tintin-2.01.0
-DISTNAME= tintin++v1.5pl6
-PKGNAME= tintin-1.5.6
-REVISION= 1
CATEGORIES= net games
-MASTER_SITES= http://ftp.kiae.su/pub/unix/games/
-EXTRACT_SUFX= .tar.Z
+HOMEPAGE= http://tintin.sourceforge.net/
+
+MAINTAINER= Ted Roby <[email protected]>
Thank you for maintaining!
Lots of whitespace. But I'll tighten that up on commit.
-# Public Domain
+# GPLv2+
PERMIT_PACKAGE_CDROM= Yes
+PERMIT_PACKAGE_FTP= Yes
If PERMIT_PACKAGE_CDROM=Yes then you don't need anything else.
~Brian
