On Fri, Feb 28, 2014 at 01:32:37PM +0100, Pascal Stumpf wrote:
> Wow, just came across this: math/cgal claims to be version 4.1, but it
> is not. The tarball contains the code for version 3.8. This part of
> the makefile should have raised suspicions, I think:
>
> \# wow, forgot to change version?
> WRKDIST = ${WRKDIR}/CGAL-3.8
>
> And indeed, just look at VERSION and CHANGES.
>
> The problem is that MASTER_SITES will let you download any
> CGAL-x.y.tar.gz and give you 3.8. If you want anything else, you have
> to change the number at the end of the URL. I can prepare an update to
> 4.3 for after unlock, but for now, I think correcting the version and
> bumping EPOCH is in order.
OK for after unlock. 5.4 was already shipping this so we'll live with 5.5
shipping with this too.
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/math/cgal/Makefile,v
> retrieving revision 1.8
> diff -u -p -r1.8 Makefile
> --- Makefile 11 Mar 2013 11:23:54 -0000 1.8
> +++ Makefile 28 Feb 2014 12:30:06 -0000
> @@ -7,8 +7,11 @@ BROKEN-mips64 = ICE on Interval_nt.h:98
>
> COMMENT = Computational Geometry Algorithms Library
>
> -DISTNAME = CGAL-4.1
> +# when updating this port, don't just change the version number here.
> +# MASTER_SITES needs to be adapted for every new tarball.
> +DISTNAME = CGAL-3.8
> PKGNAME = ${DISTNAME:L}
> +EPOCH = 0
>
> SHARED_ONLY = Yes
> SHARED_LIBS = CGAL 0.0 \
> @@ -35,9 +38,6 @@ MODULES = devel/cmake \
> LIB_DEPENDS = devel/boost \
> devel/gmp \
> devel/mpfr
> -
> -# wow, forgot to change version?
> -WRKDIST = ${WRKDIR}/CGAL-3.8
>
> CFLAGS += -I${X11BASE}/include
>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/math/cgal/distinfo,v
> retrieving revision 1.2
> diff -u -p -r1.2 distinfo
> --- distinfo 8 Mar 2013 01:26:55 -0000 1.2
> +++ distinfo 28 Feb 2014 12:30:06 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (CGAL-4.1.tar.gz) = se3VGIYTTPCG0XmCxQ9xAleBFWHSiLQ5rzprxjI4ntQ=
> -SIZE (CGAL-4.1.tar.gz) = 14112547
> +SHA256 (CGAL-3.8.tar.gz) = se3VGIYTTPCG0XmCxQ9xAleBFWHSiLQ5rzprxjI4ntQ=
> +SIZE (CGAL-3.8.tar.gz) = 14112547
