On 2014/05/07 17:16, Brian Callahan wrote:
>
> On 05/07/14 16:16, Alexandre Ratchov wrote:
> >I just discoved my favourite audio player, siren. And to my
> >surprise it already has sndio support upstream. Very cool.
> >
> >Comments? OK?
>
> Just a quick lookover from me; will have time later tonight for real testing
> on other archs:
> * No need for VERSION since it only appears once, can just do
> DISTNAME=siren-0.3.1
> * Don't need EXTRACT_SUFX, .tar.gz is the default.
> * I'm not sure PFRAG.shared is desired here.
Looks like these are required parts of the program, in which
case mark the port as SHARED_ONLY=Yes, remove plist/pfrag
files and regen (the pfrag.shared will disapperar).
> * NO_TEST=Yes
>
> ~Brian
>
> >Index: siren/Makefile
> >===================================================================
> >RCS file: siren/Makefile
> >diff -N siren/Makefile
> >--- /dev/null 1 Jan 1970 00:00:00 -0000
> >+++ siren/Makefile 7 May 2014 10:34:25 -0000
> >@@ -0,0 +1,20 @@
> >+# $OpenBSD$
> >+
> >+COMMENT= a text-based audio player
> >+VERSION= 0.3.1
> >+DISTNAME= siren-${VERSION}
> >+CATEGORIES= audio
> >+HOMEPAGE= http://www.kariliq.nl/siren/
> >+MAINTAINER= Alexandre Ratchov <[email protected]>
> >+
> >+# BSD
> >+PERMIT_PACKAGE_CDROM= Yes
> >+
> >+MASTER_SITES= ${HOMEPAGE}/dist/
> >+EXTRACT_SUFX= .tar.gz
> >+WANTLIB= c curses m pthread sndio z FLAC id3tag mad sndfile
> >vorbisfile
> >+LIB_DEPENDS= audio/flac audio/libid3tag audio/libmad
> >audio/libsndfile audio/libvorbis
> >+CONFIGURE_STYLE= simple
> >+CONFIGURE_ARGS= prefix=${PREFIX} ao=no oss=no pulse=no sun=no
> >wavpack=no
please follow standard ports Makefile style for line formatting.
(also tar/tar.gz are preferred, "/dev/null diffs" are harder to test).
