On Thu, May 8, 2014 at 11:10 AM, Alexandre Ratchov <[email protected]> wrote: > On Wed, May 07, 2014 at 11:10:46PM +0100, Stuart Henderson wrote: >> On 2014/05/07 17:16, Brian Callahan wrote: >> > >> > Just a quick lookover from me; will have time later tonight for real >> > testing >> > on other archs: >> > * No need for VERSION since it only appears once, can just do >> > DISTNAME=siren-0.3.1 >> > * Don't need EXTRACT_SUFX, .tar.gz is the default. >> > * I'm not sure PFRAG.shared is desired here. >> >> Looks like these are required parts of the program, in which >> case mark the port as SHARED_ONLY=Yes, remove plist/pfrag >> files and regen (the pfrag.shared will disapperar). >> >> > * NO_TEST=Yes >> > >> >> please follow standard ports Makefile style for line formatting. >> (also tar/tar.gz are preferred, "/dev/null diffs" are harder to test). > > Thanks for the comments and sorry for having missed the trivial > ones. Below is a new version of the port, with these chages: > > - expanded & removed ${VERSION} > - removed EXTRACT_SUFX > - added SHARED_ONLY=Yes and comment with the reason > - removed PFRAG.shared and regenerated PLIST > - use "+=" for WANTLIB as other ports do > - spacing, new line for each LIB_DEPENDS & CONFIGURE_ARGS > - added NO_TEST=Yes > > and the forgotten audio/Makefile change: > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/audio/Makefile,v > retrieving revision 1.325 > diff -u -p -u -p -r1.325 Makefile > --- Makefile 6 May 2014 14:02:17 -0000 1.325 > +++ Makefile 8 May 2014 09:09:33 -0000 > @@ -226,6 +226,7 @@ > SUBDIR += shntool > SUBDIR += shorten > SUBDIR += sidplay > + SUBDIR += siren > SUBDIR += snack > SUBDIR += solfege > SUBDIR += sonata > > > -- Alexandre
One fix regarding COMMENT: s/"a text-based audio player"/"text-based audio player"/ Apart from this minor inaccuracy, the port looks fine: ok dcoppa@ to import it. Ciao! David
