On 06/09/14 14:59, Stuart Henderson wrote:
On 2014/06/09 16:15, Florian Stinglmayr wrote:
Hi list,

thanks to the work and comments from bcallah@ here is a fixed up port.
It now depends on python as well, allowing it to run perl and python
scripts.

Florian
This PLIST is missing some directories; it creates files in
directories which are neither listed in the PLIST nor come from a
dependent port, e.g. share/appdata, share/locale/ja_JP, lib/hexchat /
lib/hexchat/plugins.

It would be better to avoid building the static-library version of
the plugins by using LIBTOOL_FLAGS = --tag=disable-static (then the
@comment'ed .a lines can go), and there's a hidden dependency on
at least libpci (sysinfo is built if it's present at configure
time, so this will fail sporadically in bulk builds), but check for
others - there are things like iso-codes in there too which may get
picked up.

There's also a missing library (LIB_DEPENDS and WANTLIB) on python,
use the appropriate variables shown in the lang/python section of
port-modules(5) to set these rather than hardcoding these.


I'm not convinced --enable-socks is useful. I see this in configure:
checking for SOCKSconnect in -lsocks5... no

Reply via email to