On Mon, Jun 09, 2014 at 07:59:05PM +0100, Stuart Henderson wrote: > This PLIST is missing some directories; it creates files in > directories which are neither listed in the PLIST nor come from a > dependent port, e.g. share/appdata, share/locale/ja_JP, lib/hexchat / > lib/hexchat/plugins. >
Fixed. > It would be better to avoid building the static-library version of > the plugins by using LIBTOOL_FLAGS = --tag=disable-static (then the > @comment'ed .a lines can go), and there's a hidden dependency on > at least libpci (sysinfo is built if it's present at configure > time, so this will fail sporadically in bulk builds), but check for > others - there are things like iso-codes in there too which may get > picked up. > sysinfo plugin is disabled. It is not needed. > There's also a missing library (LIB_DEPENDS and WANTLIB) on python, > use the appropriate variables shown in the lang/python section of > port-modules(5) to set these rather than hardcoding these. > > something's wrong with the --enable-socks, it doesn't pick up an > installed libsocks? if it's not doing anything useful should it just > be disabled? > - empty PFRAG.shared; but because you use loadable modules it should be > SHARED_ONLY so there shouldn't be a PFRAG.shared Also fixed. Thanks again, for all your helpful suggestions and comments. Attached is a new version of the port with all those fixes. Regards, Florian
