On 2014/07/18 14:16, Jason Tubnor wrote:
> Hi,
>
> I have done a little cleaning from my original effort in updating this
> port. Could someone review it (provide feedback if necessary) and
> possibly submit it.
>
> The patch-Makefile looks the same but there were ^M through the one in
> cvs which caused patching to barf.
Please send this patch as a gzipped attachment; normally what you
have done is exactly correct, but in the case where you have a diff
containing control characters it won't make it cleanly through mail.
(Note to readers: if you must patch a file with MS-DOS line endings,
*please* if possible convert the line-endings for those files in a
pre-patch target).
> COMMENT= HDHomeRun Config CLI utility & firmware
> -FW= hdhomerun_atsc_firmware_20110323.bin \
> - hdhomerun_dvbt_firmware_20110323.bin \
> - hdhomerun_tech_atsc_firmware_20110323.bin \
> - hdhomerun3_atsc_firmware_20110323.bin \
> - hdhomerun3_dvbt_firmware_20110323.bin \
> - hdhomerun3_dvbtc_firmware_20110323.bin
> -SRC= libhdhomerun_20110323.tgz
> +FW= hdhomerun_atsc_firmware_20140604.bin \
> + hdhomerun_dvbt_firmware_20140604.bin \
> + hdhomerun3_atsc_firmware_20140604.bin \
> + hdhomerun3_dvbt_firmware_20140604.bin \
> + hdhomerun3_dvbtc_firmware_20140604.bin \
> + hdhomerun3_cablecard_firmware_20140604.bin \
> + hdhomerun3_dvbc_firmware_20140604.bin \
> + hdhomerun4_atsc_firmware_20140604.bin \
> + hdhomeruntc_atsc_firmware_20140604.bin
> +SRC= libhdhomerun_20140604.tgz
> DISTFILES= ${FW} ${SRC}
> EXTRACT_ONLY= ${SRC}
> -PKGNAME= hdhomerun-20110323
> +PKGNAME= hdhomerun-20140604
> REVISION= 0
Please drop the REVISION line, and I would use a variable to replace
all the dates and add it to SUBST_VARS e.g.
V= 20140604
FW= hdhomerun_atsc_firmware_$V.bin \
hdhomerun_dvbt_firmware_$V.bin
SUBST_VARS+= V
etc. - then "make plist" to regenerate the PLIST file which will
then replace the dates in there with ${V} as well. Saves file churn
when updating (and makes future diffs easier to read).
