On 18 July 2014 21:28, Stuart Henderson <[email protected]> wrote: > > have done is exactly correct, but in the case where you have a diff > containing control characters it won't make it cleanly through mail.
> (Note to readers: if you must patch a file with MS-DOS line endings,
> *please* if possible convert the line-endings for those files in a
> pre-patch target).
The patch-Makefile that is included removes the control characters as
the one in cvs has the control characters in it. Not sure how the
hdhomerun Makefile worked in the past (must have had control
characters in the Makefile only at some point), but the current
release has the control characters removed.
> Please drop the REVISION line, and I would use a variable to replace
> all the dates and add it to SUBST_VARS e.g.
>
> etc. - then "make plist" to regenerate the PLIST file which will
> then replace the dates in there with ${V} as well. Saves file churn
> when updating (and makes future diffs easier to read).
Done.
Thanks for the feedback. Please see attached gzip and advise if there
is anything else needing attention.
hdhomerun-20140604-patch.gz
Description: GNU Zip compressed data
