On 11/12/14 20:48, Fred wrote: > On 11/12/14 17:29, Jungle Boogie wrote: >> Hello Managers of Ports, >> >> I noticed the port and package of ack[0] is quite outdated, from >> December 2013[1]. >> >> I don't know what it takes to have it updated in ports/packages but I'd >> greatly appreciate any considering to do so! >> >> Thanks, >> Jungle >> >> [0] http://beyondgrep.com/ >> [1] http://beyondgrep.com/changes.txt >> -- >> inum: 883510009027723 >> sip: [email protected] >> xmpp: [email protected] >> > > Hi, > > The diff below will bring ack up to 2.14. > > I've emailed the maintainer as well. > > Cheers > > Fred > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/textproc/p5-ack/Makefile,v > retrieving revision 1.17 > diff -u -p -u -r1.17 Makefile > --- Makefile 22 Oct 2014 14:24:13 -0000 1.17 > +++ Makefile 12 Nov 2014 20:44:38 -0000 > @@ -3,7 +3,7 @@ > COMMENT= grep like tool, aimed at programmers > > MODULES= cpan > -DISTNAME= ack-2.12 > +DISTNAME= ack-2.14 > REVISION= 0 > CPAN_AUTHOR= PETDANCE > CATEGORIES= textproc > Index: distinfo > =================================================================== > RCS file: /cvs/ports/textproc/p5-ack/distinfo,v > retrieving revision 1.10 > diff -u -p -u -r1.10 distinfo > --- distinfo 12 Dec 2013 17:26:11 -0000 1.10 > +++ distinfo 12 Nov 2014 20:44:38 -0000 > @@ -1,2 +1,2 @@ > -SHA256 (ack-2.12.tar.gz) = UvLTe8JXDZRxcfEAWdbtTw8jQThJpUbKICtuF967fSs= > -SIZE (ack-2.12.tar.gz) = 219614 > +SHA256 (ack-2.14.tar.gz) = hUmoM+/sFY3IW8YzSzo4SuWjiYlpQuq5pYxuYwwYGz8= > +SIZE (ack-2.14.tar.gz) = 222479 > > Try the attached ....
a) I checked META.json / Makefile.pl for dependency changes / version requirement changes. Version is 1.10 not 1.1 for p5-File-Next, we have 1.12 so 1.10 check will pass. b) Tests some had been skipped because of missing dependencies, added the extra dependencies required for these tests. All tests do pass apart from one skipped test. The one test being skipped is unfinished upstream, even latest in github. Besides make test, make port-lib-depends-check, portcheck should be run, neither reported any issues, only tested on amd64. Also checked for other packages using p5-ack, none, so no additional checks required or carried out. There are a lot of upstream commits after 2.14, not sure how stable the 2.14 version is. ChangeLog contains a concern about problem introduced in 2.14, Commit history another, but ignored as related to a test. If some of these later changes are required the port needs patches adding until next version is released.
Index: Makefile =================================================================== RCS file: /home/cvs/ports/textproc/p5-ack/Makefile,v retrieving revision 1.17 diff -u -p -r1.17 Makefile --- Makefile 22 Oct 2014 14:24:13 -0000 1.17 +++ Makefile 12 Nov 2014 19:17:47 -0000 @@ -3,8 +3,7 @@ COMMENT= grep like tool, aimed at programmers MODULES= cpan -DISTNAME= ack-2.12 -REVISION= 0 +DISTNAME= ack-2.14 CPAN_AUTHOR= PETDANCE CATEGORIES= textproc @@ -15,6 +14,8 @@ HOMEPAGE = http://beyondgrep.com/ PERMIT_PACKAGE_CDROM= Yes BUILD_DEPENDS= ${RUN_DEPENDS} -RUN_DEPENDS= devel/p5-File-Next>=1.1 +RUN_DEPENDS= devel/p5-File-Next>=1.10 +TEST_DEPENDS += devel/p5-IO-Tty \ + shells/bash .include <bsd.port.mk> Index: distinfo =================================================================== RCS file: /home/cvs/ports/textproc/p5-ack/distinfo,v retrieving revision 1.10 diff -u -p -r1.10 distinfo --- distinfo 12 Dec 2013 17:26:11 -0000 1.10 +++ distinfo 12 Nov 2014 18:15:33 -0000 @@ -1,2 +1,2 @@ -SHA256 (ack-2.12.tar.gz) = UvLTe8JXDZRxcfEAWdbtTw8jQThJpUbKICtuF967fSs= -SIZE (ack-2.12.tar.gz) = 219614 +SHA256 (ack-2.14.tar.gz) = hUmoM+/sFY3IW8YzSzo4SuWjiYlpQuq5pYxuYwwYGz8= +SIZE (ack-2.14.tar.gz) = 222479
