YASUOKA Masahiko <[email protected]> writes:
> I'd like to add mail/mew to our ports.
>
> It had been a port once and it had been deleted last year since it had
> depended emacs21. Actually it works with many emacs versions.
The problem is that we can't have a port that depends on emacs21 at
build time, since emacs21 and emacs conflict. You have to enforce
a build dep on emacs>=24. I'd also suggest to enforce emacs>=24 as
a run dep (if only because the files byte-compiled by emacs>=24 *may*
not be usable by emacs21).
> Also
> it still polular in Japanese BSD/UNIX community and I myself is using
> it heavily for my daily work. I'd like to revive it and I'd like to
> become the maintainer of it.
>
> The attached mew.tar.gz is based on the old port and work by
> gsoares@.
The following should be addressed:
- there are two WANTLIB lines, the second one is bogus;
${MODRUBY_WANTLIB} is not needed, since no executable / gem in this
port links against libruby
- build/run dep on "emacs->=24:editors/emacs"
- the run depends should be split, each on their own line
- speaking of the run deps on hyperestraier / ruby, aren't they
optional? If they are then I'd suggest to document them (pkg/README)
instead of forcing a hard dep. Also, is ruby1.8 needed for these
scripts? I heard ruby1.8 was dead upstream, and could one day leave
the ports tree.
- please use MODRUBY_ADJ_FILES, don't roll your own
- USE_GROFF doesn't seem needed (same output, no mandoc(1) warnings)
- please use ${PREFIX}, not $(PREFIX) in CONFIGURE_ARGS
It's a shame that the info file can't be handled more seamlessly, but
since I've just lost 10mn trying to make it fit, I won't object on that
part. :)
Cheers,
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
