Hi, On Tue, 26 May 2015 01:32:32 +0200 [email protected] (Jérémie Courrèges-Anglas) wrote: > YASUOKA Masahiko <[email protected]> writes: >> I'd like to add mail/mew to our ports. >> >> It had been a port once and it had been deleted last year since it had >> depended emacs21. Actually it works with many emacs versions. > > The problem is that we can't have a port that depends on emacs21 at > build time, since emacs21 and emacs conflict. You have to enforce > a build dep on emacs>=24. I'd also suggest to enforce emacs>=24 as > a run dep (if only because the files byte-compiled by emacs>=24 *may* > not be usable by emacs21).
I see. I noticed Mew itself is no longer supporting emacs21, it
recommends 22.3 or later. So I think there is no problem to enforce
the build/run dep on emacs>=24.
>> Also
>> it still polular in Japanese BSD/UNIX community and I myself is using
>> it heavily for my daily work. I'd like to revive it and I'd like to
>> become the maintainer of it.
>>
>> The attached mew.tar.gz is based on the old port and work by
>> gsoares@.
>
> The following should be addressed:
>
> - there are two WANTLIB lines, the second one is bogus;
> ${MODRUBY_WANTLIB} is not needed, since no executable / gem in this
> port links against libruby
done.
> - build/run dep on "emacs->=24:editors/emacs"
done.
> - the run depends should be split, each on their own line
done.
> - speaking of the run deps on hyperestraier / ruby, aren't they
> optional? If they are then I'd suggest to document them (pkg/README)
> instead of forcing a hard dep.
Mew is using many optional programs. hyperestraier is one of them.
So I'd make it not forcing a hard dep. As for ruby, it seems for me
"ruby" is a special for Mew since it is used without any note.) So
I'd keep it forcing a hard dep.
> Also, is ruby1.8 needed for these scripts? I heard ruby1.8 was
> dead upstream, and could one day leave the ports tree.
I verified the ruby programs (smew and cmew are the program) in Mew
can run with ruby versions 1.8, 2.0, 2.1 and 2.2, so I deleted
MODRUBY_REV.
Also I added security/stunnel to the run dep, since it is used with
Mew almost all case.
> - please use MODRUBY_ADJ_FILES, don't roll your own
done.
> - USE_GROFF doesn't seem needed (same output, no mandoc(1) warnings)
done.
> - please use ${PREFIX}, not $(PREFIX) in CONFIGURE_ARGS
done.
Also:
- deleted the sentence about "search services" from pkg/DESCR for
the moment. I have a plan to add another additional port for
search, I'd like to update about "search" after that.
- added 00* documents and dot.* sample files to
/usr/share/doc/mew/. The same idea of FreeBSD port.
> It's a shame that the info file can't be handled more seamlessly, but
> since I've just lost 10mn trying to make it fit, I won't object on that
> part. :)
I think I did it. Tested on info(1) and emacs, but I'm not sure it's
enough.
I attached the update mew.tar.gz. How about this?
--yasuoka
mew.tar.gz
Description: Binary data
