On Sat, 19 Sep 2015, Donovan Watteau wrote: > On Mon, 31 Aug 2015, Jérémie Courrèges-Anglas wrote: > > Donovan Watteau <[email protected]> writes: > > > > > On Sat, 29 Aug 2015, Stuart Henderson wrote: > > >> On 2015/08/29 11:16, Donovan Watteau wrote: > > >> > Hi, > > >> > > > >> > Here's a new port for libdiscid, which my next audio/cmus update > > >> > will use. > > >> > > > >> > I tried cleaning some strcpy(), strcat() and sprintf(). "make test" > > >> > is still fine. If patch-src_disc_c looks good to you, I'll submit it > > >> > to upstream. > > >> > > > >> > Tested on macppc. > > >> > > >> Upstream will need some glue to make that work on OS with deficient > > >> versions of libc. In most cases we don't add this type of patch in ports > > >> as it often gets in the way of updates, but feeding upstream (if they'll > > >> take it) is good. > > > > > > Yes, I was working on submitting it to upstream with all the necessary > > > libc glue, but OK. > > > > > > So here's the port again, without the patch. > > > > Looks fine to me, two nits: > > > > 1. > > CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \ > > LDFLAGS="-L${LOCALBASE}/lib" \ > > ac_cv_header_musicbrainz5_mb5_c_h=no > > > > If there is no dep on other packages then there is no need to tweak > > CPP/LDFLAGS. And if usr/local isn't in those flags, > > ac_cv_header_musicbrainz5_mb5_c_h=no is not needed (but you may want to > > keep it for documentation). > > OK, I'll simplify this. ac_cv_header_musicbrainz5_mb5_c_h=no is enough. > > > 2. Any idea why two tests out of four are skipped? > > > > ... > > Looks like it happens when you don't have a CD-ROM drive... > > On loongson, I see this: > > ======================================= > libdiscid 0.6.1: ./test-suite.log > ======================================= > > # TOTAL: 4 > # PASS: 2 > # SKIP: 2 > # XFAIL: 0 > # FAIL: 0 > # XPASS: 0 > # ERROR: 0 > > .. contents:: :depth: 2 > > SKIP: test_read > =============== > > Testing discid_has_feature ... OK > Testing discid_read_sparse ... SKIP > Testing discid_get_error_msg ... OK > cannot open device `/dev/rcd0c' > > > SKIP: test_read_full > ==================== > > Testing discid_has_feature ... OK > Testing discid_read ... SKIP > Testing discid_get_error_msg ... OK > cannot open device `/dev/rcd0c' > > > Don't know what is the best way to deal with this. Adding a comment? > TEST_IS_INTERACTIVE=Yes ? >
So, it looks like you even need an audio CD in your drive to pass all the tests. So TEST_IS_INTERACTIVE=Yes looks good to me. So here's my port again. Thanks.
libdiscid_v3.tgz
Description: Binary data
