Donovan Watteau <[email protected]> writes: [...]
>> > Looks fine to me, two nits:
>> >
>> > 1.
>> > CONFIGURE_ENV= CPPFLAGS="-I${LOCALBASE}/include" \
>> > LDFLAGS="-L${LOCALBASE}/lib" \
>> > ac_cv_header_musicbrainz5_mb5_c_h=no
>> >
>> > If there is no dep on other packages then there is no need to tweak
>> > CPP/LDFLAGS. And if usr/local isn't in those flags,
>> > ac_cv_header_musicbrainz5_mb5_c_h=no is not needed (but you may want to
>> > keep it for documentation).
>>
>> OK, I'll simplify this. ac_cv_header_musicbrainz5_mb5_c_h=no is enough.
>>
>> > 2. Any idea why two tests out of four are skipped?
>> >
>> > ...
>>
>> Looks like it happens when you don't have a CD-ROM drive...
>>
>> On loongson, I see this:
>>
>> =======================================
>> libdiscid 0.6.1: ./test-suite.log
>> =======================================
>>
>> # TOTAL: 4
>> # PASS: 2
>> # SKIP: 2
>> # XFAIL: 0
>> # FAIL: 0
>> # XPASS: 0
>> # ERROR: 0
>>
>> .. contents:: :depth: 2
>>
>> SKIP: test_read
>> ===============
>>
>> Testing discid_has_feature ... OK
>> Testing discid_read_sparse ... SKIP
>> Testing discid_get_error_msg ... OK
>> cannot open device `/dev/rcd0c'
>>
>>
>> SKIP: test_read_full
>> ====================
>>
>> Testing discid_has_feature ... OK
>> Testing discid_read ... SKIP
>> Testing discid_get_error_msg ... OK
>> cannot open device `/dev/rcd0c'
>>
>>
>> Don't know what is the best way to deal with this. Adding a comment?
>> TEST_IS_INTERACTIVE=Yes ?
>>
>
> So, it looks like you even need an audio CD in your drive to pass all
> the tests. So TEST_IS_INTERACTIVE=Yes looks good to me.
>
> So here's my port again. Thanks.
Looks good to me. I'm not sure whether TEST_IS_INTERACTIVE=Yes is
really needed, actually I don't really care. :) Maybe others have
a stronger opinion.
Please folks, can I get reviews / oks to import this?
Re-attaching the port here for convenience,
libdiscid_v3.tgz
Description: Binary data
-- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
