On 2015/09/23 12:58, Vincent Gross wrote:
> Hi,
>
> update this port to latest version, add test_depends and licence.
>
> ok ?
>
> --
> Vincent Gross
>
> Index: mail/p5-Email-Valid/Makefile
> ===================================================================
> RCS file: /cvs/ports/mail/p5-Email-Valid/Makefile,v
> retrieving revision 1.16
> diff -u -p -r1.16 Makefile
> --- mail/p5-Email-Valid/Makefile 21 Jan 2015 06:13:49 -0000 1.16
> +++ mail/p5-Email-Valid/Makefile 23 Sep 2015 10:56:03 -0000
> @@ -3,16 +3,18 @@
> COMMENT= check validity of Internet email addresses
>
> MODULES= cpan
> -DISTNAME= Email-Valid-0.184
> -REVISION= 1
> +DISTNAME= Email-Valid-1.196
> +REVISION= 0
please remove REVISION rather than setting to 0. (but if you're working
on a port which uses EPOCH, that has to stay).
> CATEGORIES= mail
>
> +# perl
> PERMIT_PACKAGE_CDROM= Yes
>
> RUN_DEPENDS= mail/p5-Mail-Tools>=1.67
> BUILD_DEPENDS= ${RUN_DEPENDS}
missing run dep:
# === Runtime Requires ===
#
# Module Want Have
# ----------------- ---- --------
# Carp any 1.3301
# File::Spec any 3.48_01
# IO::CaptureOutput any missing
# IO::File any 1.16
# Mail::Address any 2.07
# Net::DNS any 1.01
# Net::Domain::TLD 1.65 1.73
# Scalar::Util any 1.38
# Test::More any 1.001002
# strict any 1.08
# warnings any 1.23
#
#
# *** WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING ***
#
# The following REQUIRED prerequisites were not satisfied:
#
# IO::CaptureOutput is not installed (any version required)
> Index: mail/p5-Email-Valid/<...>
minor point, but unless you're sending diffs for a bunch of ports in
one go, it's usually easier for the reviewer to do a diff from the
port directory itself rather than /usr/ports.
