On 09/23/15 13:23, Stuart Henderson wrote:
> please remove REVISION rather than setting to 0. (but if you're working
> on a port which uses EPOCH, that has to stay).
fixed.
> missing run dep:
fixed. While at it I removed BUILD_DEPENDS as the whole package can be built
without the RUN_DEPENDS being installed.
> minor point, but unless you're sending diffs for a bunch of ports in
> one go, it's usually easier for the reviewer to do a diff from the
> port directory itself rather than /usr/ports.
Noted.
New diff:
Index: Makefile
===================================================================
RCS file: /cvs/ports/mail/p5-Email-Valid/Makefile,v
retrieving revision 1.16
diff -u -p -r1.16 Makefile
--- Makefile 21 Jan 2015 06:13:49 -0000 1.16
+++ Makefile 23 Sep 2015 11:46:07 -0000
@@ -3,16 +3,16 @@
COMMENT= check validity of Internet email addresses
MODULES= cpan
-DISTNAME= Email-Valid-0.184
-REVISION= 1
+DISTNAME= Email-Valid-1.196
CATEGORIES= mail
+# perl
PERMIT_PACKAGE_CDROM= Yes
-RUN_DEPENDS= mail/p5-Mail-Tools>=1.67
-BUILD_DEPENDS= ${RUN_DEPENDS}
-
-TEST_DEPENDS= net/p5-Net-Domain-TLD
+RUN_DEPENDS= mail/p5-Mail-Tools>=1.67 \
+ devel/p5-IO-CaptureOutput \
+ net/p5-Net-Domain-TLD>=1.65 \
+ net/p5-Net-DNS
MAKE_ENV= TEST_POD=Yes
Index: distinfo
===================================================================
RCS file: /cvs/ports/mail/p5-Email-Valid/distinfo,v
retrieving revision 1.9
diff -u -p -r1.9 distinfo
--- distinfo 18 Jan 2015 03:14:23 -0000 1.9
+++ distinfo 23 Sep 2015 11:46:07 -0000
@@ -1,2 +1,2 @@
-SHA256 (Email-Valid-0.184.tar.gz) =
rYGThqEZm3t75GLpvgY0OLAonnZH27pLS4Vp+ZNYjy0=
-SIZE (Email-Valid-0.184.tar.gz) = 17958
+SHA256 (Email-Valid-1.196.tar.gz) =
dRIc4lwaUwB2tlpZQjJtA7/MXRXUgOhkG2qEqDv1Qmg=
+SIZE (Email-Valid-1.196.tar.gz) = 32208
