Gregor Best <[email protected]> writes: > On Mon, Oct 12, 2015 at 04:46:03PM +0200, Gregor Best wrote: >> On Mon, Oct 12, 2015 at 01:31:36AM +0300, Vadim Zhukov wrote: >> > [...] >> > This software changes default CMake variables depending on presence of >> > popt library and xmlto binary at least. So you have hidden >> > dependencies there. You'd either explicitly disable picking up those >> > by -DCMAKE_DISABLE_FIND_PACKAGE_Foo=True, or add what you think worths >> > it to BUILD/LIB/RUN_DEPENDS. >> > [...] >> >> Whoops, fixed that. I've disabled API-doc generation because it pulls in >> devel/doxygen as a build dependency and explicitly added popt and xmlto >> to lib and build dependencies. >> >> This one also installs the manual pages into the right place. >> [...] > > Ping. > > Is there something still missing about the port?
A few tweaks: - please follow the ordering as show in infrastructure/templates/Makefile.template, it helps a lot to have consistency here - the shared library version in the OpenBSD ports tree does not follow the one defined upstream, thus we start with 0.0 for a new port. For more about shared libs in ports, see http://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs I think it is ready to import, can I get other reviews / oks? Updated tarball attached, diff of the changes I introduced below. Cheers, diff -pruN rabbitmq-c.orig/Makefile rabbitmq-c/Makefile --- rabbitmq-c.orig/Makefile Mon Oct 12 16:45:39 2015 +++ rabbitmq-c/Makefile Thu Nov 5 13:29:14 2015 @@ -1,3 +1,5 @@ +# $OpenBSD$ + COMMENT= rabbitmq C library and commandline AMQP utilities V= 0.7.0 @@ -6,12 +8,17 @@ GH_PROJECT= rabbitmq-c GH_TAGNAME= v${V} DISTNAME= ${GH_PROJECT}-${V} +SHARED_LIBS = rabbitmq 0.0 # 4.1 + CATEGORIES= net HOMEPAGE= https://github.com/${GH_ACCOUNT}/${GH_PROJECT} MAINTAINER= Gregor Best <[email protected]> +# MIT +PERMIT_PACKAGE_CDROM = Yes + MODULES= devel/cmake WANTLIB= c crypto popt pthread ssl @@ -22,10 +29,5 @@ BUILD_DEPENDS= textproc/xmlto CONFIGURE_ARGS= -DBUILD_TOOLS_DOCS=ON \ -DCMAKE_DISABLE_FIND_PACKAGE_Doxygen=True \ -DBUILD_API_DOCS=OFF - -SHARED_LIBS = rabbitmq 4.1 - -# MIT -PERMIT_PACKAGE_CDROM = Yes .include <bsd.port.mk>
rabbitmq-c.tgz
Description: Binary data
-- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
