[email protected] (Jérémie Courrèges-Anglas) writes:

> Gregor Best <[email protected]> writes:
>
>> On Mon, Oct 12, 2015 at 04:46:03PM +0200, Gregor Best wrote:
>>> On Mon, Oct 12, 2015 at 01:31:36AM +0300, Vadim Zhukov wrote:
>>> > [...]
>>> > This software changes default CMake variables depending on presence of
>>> > popt library and xmlto binary at least. So you have hidden
>>> > dependencies there. You'd either explicitly disable picking up those
>>> > by -DCMAKE_DISABLE_FIND_PACKAGE_Foo=True, or add what you think worths
>>> > it to BUILD/LIB/RUN_DEPENDS.
>>> > [...]
>>> 
>>> Whoops, fixed that. I've disabled API-doc generation because it pulls in
>>> devel/doxygen as a build dependency and explicitly added popt and xmlto
>>> to lib and build dependencies.
>>> 
>>> This one also installs the manual pages into the right place.
>>> [...]
>>
>> Ping.
>>
>> Is there something still missing about the port?
>
> A few tweaks:
> - please follow the ordering as show in
>   infrastructure/templates/Makefile.template, it helps a lot to have
>   consistency here
> - the shared library version in the OpenBSD ports tree does not follow
>   the one defined upstream, thus we start with 0.0 for a new port.  For
>   more about shared libs in ports, see
>   http://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs
>
> I think it is ready to import, can I get other reviews / oks?

ping :)

Attachment: rabbitmq-c.tgz
Description: Binary data

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to