On 2015/12/10 10:39, Jan Stary wrote: > On Nov 24 23:16:21, h...@stare.cz wrote: > > This updates audio/libsndfile to the new release. > > > > * CVE-2014-9756 fixed upstream, drop the patch > > * share/doc/libsndfile/pkgconfig.html removed > > * man1/sndfile-salvage.1 added > > > > Also, upstream has accepted a complete rewrite of the manpages > > into mdoc(7). Thanks to schwarze and jmc for the guidance. > > (This happend about a year ago, a release only came out now.) > > On Nov 25 10:29:45, st...@openbsd.org wrote: > > Some exported functions were removed, so this one does need a major > > bump (no need to send a new diff just for that though). > > > > removed: > > pchk4_find > > pchk4_store > > Thanks, I missed that. > What is the preferred way to check for these changes? > Do you just nm(1) the two libraries and look for the diff?
That's usually the first step, there's an example nm command shown in http://www.openbsd.org/faq/ports/specialtopics.html. This doesn't cover everything though - if function parameters change then it also needs a major bump - but if you see removed functions you don't need to check any further. > > Otherwise looks good to me, I'll test on macppc, I can commit this > > later if nobody runs into problems with it. > > There don't seem to be huge changes, but it was 4 years since the > > last upstream release so being slightly cautious :) > > Oh yes. The first mention of "new release in a few weeks" > happened years ago :-) > > > On Nov 25 10:54:43, st...@openbsd.org wrote: > > There are a number of test failures on macppc, though they occur in > > the existing version too so I don't think they should block the update > > but might be worth talking to upstream about. > > I am in touch with upstream about these errors. > In fact, they appear on other archs and other OSes too. > > OK to commit then? Thanks - I'll commit it.
