On Fri, Dec 18, 2015 at 10:41:11AM +0100, Landry Breuil wrote: > On Thu, Dec 17, 2015 at 10:40:12PM +0100, Rafael Sadowski wrote: > > On Fri Dec 11, 2015 at 10:43:43AM +0000, Stuart Henderson wrote: > > > On 2015/12/11 11:24, Landry Breuil wrote: > > > > On Thu, Dec 10, 2015 at 11:57:43PM +0100, Rafael Sadowski wrote: > > > > > Hey everybody, > > > > > > > > > > for those who can not wait (like me) here is an update for keepassx. > > > > > I hope steven@ can use it for more tests or a better port. > > > > > > > > > > Tested @amd64 with my old *.kdb file without problems. > > > > > > > > Works fine for me on amd64 too, imported my .kdb without issues. > > > > You have some things to fix in the port though: > > > > - use gtk-update-icon-cache, add an RDEP for it > > > > - fix the PLIST, it seems some icons are duplicated/installed twice > > > > - i think you can use SHARED_ONLY=yes and merge PFRAG.list into PLIST > > > > > > > > Are you sure you need ports gcc ? > > > > > > It's not needed with "CONFIGURE_ARGS= -DWITH_CXX11=no". > > > > > > I get these with port-lib-depends-check: > > > > > > Missing: Xi.12 (/usr/local/lib/keepassx/libkeepassx-autotype-x11.so) > > > (system lib) > > > Extra: QtXml.8 > > > > Dear keepassx users and port veterans, > > > > after long workdays before the Xmas break, here is a new updated diff > > with your hints: > > > > - add DWITH_CXX11=no > > - fix WANTLIB > > - fix and add LIB_DEPENDS > > - SHARED_ONLY tagged > > - fix PLIST > > - add gtk-update-icon-cache (advice from portcheck) > > > > Okay? (Okay from steven@ to update keepassx -- not for the patch (at the > > moment)) > > Looks good to me too, the only thing that saddens me is seeing icons > duplicated, ie: > > > +share/icons/hicolor/128x128/apps/keepassx.png > > +share/icons/hicolor/128x128/mimetypes/application-x-keepassx.png > > +share/icons/hicolor/16x16/apps/keepassx.png > > +share/icons/hicolor/16x16/mimetypes/application-x-keepassx.png > > +share/icons/hicolor/22x22/mimetypes/application-x-keepassx.png > > +share/icons/hicolor/24x24/apps/keepassx.png > > +share/icons/hicolor/256x256/apps/keepassx.png > > +share/icons/hicolor/32x32/apps/keepassx.png > > +share/icons/hicolor/32x32/mimetypes/application-x-keepassx.png > > +share/icons/hicolor/48x48/apps/keepassx.png > > +share/icons/hicolor/64x64/apps/keepassx.png > > +share/icons/hicolor/64x64/mimetypes/application-x-keepassx.png > > +share/icons/hicolor/scalable/apps/keepassx.svgz > > > +share/keepassx/icons/application/128x128/apps/keepassx.png > > +share/keepassx/icons/application/128x128/mimetypes/application-x-keepassx.png > > +share/keepassx/icons/application/16x16/apps/keepassx.png > > +share/keepassx/icons/application/16x16/mimetypes/application-x-keepassx.png > > +share/keepassx/icons/application/22x22/mimetypes/application-x-keepassx.png > > +share/keepassx/icons/application/24x24/apps/keepassx.png > > +share/keepassx/icons/application/256x256/apps/keepassx.png > > +share/keepassx/icons/application/32x32/apps/keepassx.png > > +share/keepassx/icons/application/32x32/mimetypes/application-x-keepassx.png > > +share/keepassx/icons/application/48x48/apps/keepassx.png > > +share/keepassx/icons/application/64x64/apps/keepassx.png > > +share/keepassx/icons/application/64x64/mimetypes/application-x-keepassx.png > > +share/keepassx/icons/application/scalable/apps/keepassx.svgz > > But i havent checked if those were symlinks or ... > > > +@exec %D/bin/gtk-update-icon-cache -q -t %D/share/icons/hicolor > > +@unexec-delete %D/bin/gtk-update-icon-cache -q -t %D/share/icons/hicolor > > Since icons are also added under share/keepassx/icons/application, maybe > gtk-update-icon-cache should be ran against this dir too.
No it shouldn't. Only icons installed under a subdirectory of PREFIX/share/icons/ should have a matching gtk-update-icon-cache. -- Antoine
