Having marked qt5 as broken, this causes parts of kde not to build
x11/kde/graphics3. qt4/qt5 didn't exist for kde which only uses qt. It's
wrong to not to build parts of kde when qt5 or qt4 is broken, and the
port causing the issue is print/poppler, or rather how poppler is being
used by other ports.


If paths print/poppler, print/poppler,, this uses a blank FLAVOR, that
means the LDEP/BDEP has x11/qt, x11/qt4, x11/qt5 all three versions of
qt are included as dependencies during the build, when only one is ever
needed by any other ports, and if building the poppler,-main/-utils none
of the qt ports are needed.

The changes for x11/kde/graphics3 editors/texmaker editors/texworks
x11/tellico are attached
print/poppler, to print/poppler (If no FLAVOR uses no_qt no_qt4 no_qt5
bootstrap for FLAVOR). Can also use print/poppler,-main
print/poppler,,-qt to print/poppler,no_qt4,no_qt5,-qt
print/poppler,,-qt4 to print/poppler,no_qt,no_qt5,-qt4

These attached changes allow me to build all kde3 and other ports while
qt5 is marked broken.

As I don't build qt5 / kde4 any more, I've not looked closely for or
made any changes to ports using qt5 or any kde4 ports. These are wrong
for a start....

$ cd /usr/ports/x11/kde4
$ grep -R print/poppler .
./nepomuk-core/Makefile:                print/poppler,,-qt4 \
./okular/Makefile:              print/poppler,,-qt4 \
./kfilemetadata/Makefile:               print/poppler,,-qt4 \


x11/tellico-kde4
textproc/calibre (print/poppler, and print/poppler,,-qt5
print/poppler print/poppler,no-qt,no-qt4,-qt5)

You can't use a BLANK FLAVOR.

Leaving unchanged has an impact on dpb build ordering, requiring qt,
qt4, qt5 all to have been built before other ports, reducing ports
available to be built in parallel/across machines, impacting on the
critical build path, as qt5 is larger and costlier than all other ports
including libreoffice and you don't want these on the same critical
path. As kde3/kde4 are involved this also has an impact on the dpb junk
when switching between kde3/kde4 builds and maybe adding additional
switches between kde3/kde4 during the build. Don't have resources to
check impact on dpb.



Ok?
Index: editors/texmaker/Makefile
===================================================================
RCS file: /home/cvs/ports/editors/texmaker/Makefile,v
retrieving revision 1.30
diff -u -p -r1.30 Makefile
--- editors/texmaker/Makefile	14 Nov 2015 15:24:44 -0000	1.30
+++ editors/texmaker/Makefile	27 Dec 2015 13:20:00 -0000
@@ -24,7 +24,7 @@ RUN_DEPENDS=		print/texlive/base \
 			devel/desktop-file-utils
 
 LIB_DEPENDS=		textproc/hunspell \
-			print/poppler,,-qt4
+			print/poppler,no_qt,no_qt5,-qt4
 
 NO_TEST=		Yes
 
Index: editors/texworks/Makefile
===================================================================
RCS file: /home/cvs/ports/editors/texworks/Makefile,v
retrieving revision 1.25
diff -u -p -r1.25 Makefile
--- editors/texworks/Makefile	25 Aug 2015 14:03:21 -0000	1.25
+++ editors/texworks/Makefile	27 Dec 2015 13:20:45 -0000
@@ -51,7 +51,7 @@ MASTER_SITES =		https://texworks.googlec
 LIB_DEPENDS-main =	qt4->=4.8.2:${MODQT4_LIB_DEPENDS} \
 			textproc/hunspell \
 			x11/dbus \
-			print/poppler,,-qt4
+			print/poppler,no_qt,no_qt5,-qt4
 LIB_DEPENDS-lua =	${MODQT4_LIB_DEPENDS} \
 			${MODLUA_LIB_DEPENDS}
 LIB_DEPENDS-python =	${MODQT4_LIB_DEPENDS} \
Index: x11/kde/graphics3/Makefile
===================================================================
RCS file: /home/cvs/ports/x11/kde/graphics3/Makefile,v
retrieving revision 1.118
diff -u -p -r1.118 Makefile
--- x11/kde/graphics3/Makefile	11 Oct 2015 14:52:52 -0000	1.118
+++ x11/kde/graphics3/Makefile	27 Dec 2015 19:19:27 -0000
@@ -47,8 +47,8 @@ LIB_DEPENDS-main = 	${LIB_DEPENDS} \
 			graphics/imlib \
 			graphics/giflib \
 			devel/fribidi>=0.19.2 \
-			print/poppler, \
-			print/poppler,,-qt
+			print/poppler \
+			print/poppler,no_qt4,no_qt5,-qt
 
 LIB_DEPENDS-kpov =	${LIB_DEPENDS}
 RUN_DEPENDS-kpov =	${RUN_DEPENDS} \
Index: x11/tellico/Makefile
===================================================================
RCS file: /home/cvs/ports/x11/tellico/Makefile,v
retrieving revision 1.34
diff -u -p -r1.34 Makefile
--- x11/tellico/Makefile	25 Aug 2015 14:03:21 -0000	1.34
+++ x11/tellico/Makefile	27 Dec 2015 13:18:21 -0000
@@ -49,7 +49,7 @@ LIB_DEPENDS=	${MODQT_LIB_DEPENDS} \
 		x11/kde/multimedia3 \
 		x11/kde/libs3 \
 		graphics/lcms \
-		print/poppler,,-qt \
+		print/poppler,no_qt4,no_qt5,-qt \
 		audio/taglib \
 		net/yaz
 

Reply via email to