28 дек. 2015 г. 3:01 пользователь "Nigel Taylor" < [email protected]> написал: > > Having marked qt5 as broken, this causes parts of kde not to build > x11/kde/graphics3. qt4/qt5 didn't exist for kde which only uses qt. It's > wrong to not to build parts of kde when qt5 or qt4 is broken, and the > port causing the issue is print/poppler, or rather how poppler is being > used by other ports. > > > If paths print/poppler, print/poppler,, this uses a blank FLAVOR, that > means the LDEP/BDEP has x11/qt, x11/qt4, x11/qt5 all three versions of > qt are included as dependencies during the build, when only one is ever > needed by any other ports, and if building the poppler,-main/-utils none > of the qt ports are needed. > > The changes for x11/kde/graphics3 editors/texmaker editors/texworks > x11/tellico are attached > print/poppler, to print/poppler (If no FLAVOR uses no_qt no_qt4 no_qt5 > bootstrap for FLAVOR). Can also use print/poppler,-main > print/poppler,,-qt to print/poppler,no_qt4,no_qt5,-qt > print/poppler,,-qt4 to print/poppler,no_qt,no_qt5,-qt4 > > These attached changes allow me to build all kde3 and other ports while > qt5 is marked broken. > > As I don't build qt5 / kde4 any more, I've not looked closely for or > made any changes to ports using qt5 or any kde4 ports. These are wrong > for a start.... > > $ cd /usr/ports/x11/kde4 > $ grep -R print/poppler . > ./nepomuk-core/Makefile: print/poppler,,-qt4 \ > ./okular/Makefile: print/poppler,,-qt4 \ > ./kfilemetadata/Makefile: print/poppler,,-qt4 \ > > > x11/tellico-kde4 > textproc/calibre (print/poppler, and print/poppler,,-qt5 > print/poppler print/poppler,no-qt,no-qt4,-qt5) > > You can't use a BLANK FLAVOR. > > Leaving unchanged has an impact on dpb build ordering, requiring qt, > qt4, qt5 all to have been built before other ports, reducing ports > available to be built in parallel/across machines, impacting on the > critical build path, as qt5 is larger and costlier than all other ports > including libreoffice and you don't want these on the same critical > path. As kde3/kde4 are involved this also has an impact on the dpb junk > when switching between kde3/kde4 builds and maybe adding additional > switches between kde3/kde4 during the build. Don't have resources to > check impact on dpb.
You have a good point, IMHO. But, if I understand correctly, this will lead to building print/poppler 4 times instead of 2 as of now. Before: print/poppler,no_qt,no_qt4,no_qt5 print/poppler, After your proposal fully implemented: print/poppler,no_qt,no_qt4,no_qt5 print/poppler,no_qt4,no_qt5 print/poppler,no_qt,no_qt5 print/poppler,no_qt,no_qt4 Since this affects bulk builds only, and I do not run bulk builds that often (especially because I do not want to rebuild ten webkits and libreoffice regularly on my laptop, Qt5 and KDE are enough) I can't okay (as in "commit it!") your diff. But I do not have any objections, either. On the other side: if this idea is accepted, we may switch to more easy concept of plain FLAVORs then... -- Vadim Zhukov
