On 2016/04/25 17:24, Stuart Henderson wrote:
> This struck me as being a bit odd, some of the configure.ac patches
> change from FOO+= to FOO=, like these:
> 
> -                     PC_REQUIRES+=(libxml-2.0)
> +                     PC_REQUIRES="libxml-2.0 ${PC_REQUIRES}"
> 
> but others retain the +
> 
> -                              PC_LIBS+=($openssl_LIBS)
> +                              PC_LIBS+="${openssl_LIBS} ${PC_LIBS}"
> 
> Shouldn't those + go away as well? (Untested due to lack of
> usable Makefile ;)
> 
> 

Tested now, it didn't break the build with them, but they should all
go away, they're a bash-ism and don't work with our shell so even if
they work now, they might trip us up later.

Otherwise ok for libstrophe, will look at profanity next.

Reply via email to