On 2017/01/17 08:15, Tobias Brodel wrote: > Please find attached a port for rubberband, a library and utility for > timestretching and repitching audio. It is one of a few new dependencies > required for an update to audio/ardour. I'm pretty new to ports so any > feedback would be much appreciated. Tested on amd64. Cheers, toby/
Hi, some quick feedback : Makefile: - "ONLY_FOR_ARCHS = amd64 i386", why? - "#GPLv2 only" please add a space, "# GPLv2 only" - "COMMENT = Library for ..." lower-case first letter -> "library for" pkg/DESCR: - don't list WWW, it comes automatically from HOMEPAGE in Makefile pkg/PLIST, Makefile: - the linux-style shared library handling needs modifying. you have: lib/librubberband.so lib/librubberband.so.2 @bin lib/librubberband.so.2.1.0 there should be a single entry, @lib lib/librubberband.so.0.0 and the ".0.0" needs to be under control of SHARED_LIBS lines in Makefile, so you'll need SHARED_LIBS= rubberband 0.0 and arrange things so you can pass this in to the build via LIBrubberband_VERSION (maybe via patching, maybe MAKE_FLAGS overrides etc). If you grep other port Makefiles for "LIB[a-z]*_VERSION" you'll find various ways that this is handled; the :R and :E constructs you'll see in some of these are to split up the "major" and "minor" versions for ports that need it. On 2017/01/17 14:20, Tobias Brodel wrote: > Lv2 is an audio plugin standard designed to replace LADSPA. (etc) Since you are pretty new to ports on OpenBSD, please get the first one in good shape before sending others, as most of my comments apply to the others too.
